Skip to content

chore: fix JavaScript lint errors (issue #11732)#11736

Merged
kgryte merged 1 commit intostdlib-js:developfrom
dimssu:chore/issue-11732-fix-lint-errors
Apr 27, 2026
Merged

chore: fix JavaScript lint errors (issue #11732)#11736
kgryte merged 1 commit intostdlib-js:developfrom
dimssu:chore/issue-11732-fix-lint-errors

Conversation

@dimssu
Copy link
Copy Markdown
Contributor

@dimssu dimssu commented Apr 23, 2026

Resolves #11732.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes a JavaScript lint error in lib/node_modules/@stdlib/_tools/pkgs/entry-points/lib/entries.js.
  • Replaces new Array( total ) with an array literal [] and push() to comply with the stdlib/no-new-array ESLint rule.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • The change is semantically equivalent: after the initialization loop runs, the resulting array has the same length and contents as before. Subsequent out[ idx ] accesses in the async done callback are unaffected since push order matches index order.
  • Verified that the stdlib/no-new-array rule no longer fires on the modified file.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I used AI assistance only to locate and understand the issue, review the change, and help draft documentation, comments, and messages. The code change itself was authored manually.


@stdlib-js/reviewers

Replace `new Array( total )` with an array literal and `push()` to
comply with the `stdlib/no-new-array` ESLint rule.

Ref: stdlib-js#11732
@dimssu dimssu requested a review from a team April 23, 2026 03:08
@stdlib-bot stdlib-bot added Tools Issue or pull request related to project tooling. Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. labels Apr 23, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Apr 27, 2026
@kgryte kgryte merged commit e1b8e98 into stdlib-js:develop Apr 27, 2026
117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. review: 5 Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants