Skip to content

chore: propagate blas/base/ndarray/* modernization fixes to sibling packages #11742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 2 commits into from
Apr 23, 2026
Merged

chore: propagate blas/base/ndarray/* modernization fixes to sibling packages #11742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb98b40
chore: align README identity check across `blas/base/ndarray/*`
claude Apr 23, 2026
03235e5
chore: modernize `scalar2ndarray` in `blas/base/ndarray/*axpy` tests
claude Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/blas/base/ndarray/caxpy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ var alpha = scalar2ndarray( new Complex64( 1.0, 2.0 ), {
var z = caxpy( [ x, y, alpha ] );
// returns <ndarray>[ <Complex64>[ -2.0, 5.0 ], <Complex64>[ -4.0, 11.0 ], <Complex64>[ -6.0, 17.0 ] ]

var bool = ( y === z );
var bool = ( z === y );
// returns true
```

Expand Down
26 changes: 19 additions & 7 deletions lib/node_modules/@stdlib/blas/base/ndarray/caxpy/test/test.js
View file
Open in desktop
Copy link
Copy Markdown
Member

@kgryte kgryte Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not necessarily needed and was originally omitted on purpose as tests are a bit trickier to uniformly align, especially as we intentionally need lower level interfaces (e.g., for stride and offset manipulation). This change is harmless, however, so I will accept it and similar changes in this PR.

Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ var tape = require( 'tape' );
var isSameComplex64Array = require( '@stdlib/assert/is-same-complex64array' );
var Complex64Array = require( '@stdlib/array/complex64' );
var Complex64 = require( '@stdlib/complex/float32/ctor' );
var scalar2ndarray = require( '@stdlib/ndarray/base/from-scalar' );
var scalar2ndarray = require( '@stdlib/ndarray/from-scalar' );
var ndarray = require( '@stdlib/ndarray/base/ctor' );
var getData = require( '@stdlib/ndarray/data-buffer' );
var caxpy = require( './../lib' );
Expand Down Expand Up @@ -95,7 +95,9 @@ tape( 'the function multiplies a one-dimensional ndarray `x` by a constant `alph
]);
x = vector( xbuf, 5, 1, 0 );
y = vector( ybuf, 5, 1, 0 );
alpha = scalar2ndarray( new Complex64( 2.0, 2.0 ), 'complex64', 'row-major' );
alpha = scalar2ndarray( new Complex64( 2.0, 2.0 ), {
'dtype': 'complex64'
});

v = caxpy( [ x, y, alpha ] );

Expand Down Expand Up @@ -128,7 +130,9 @@ tape( 'the function multiplies a one-dimensional ndarray `x` by a constant `alph
]);
x = vector( xbuf, 2, 1, 0 );
y = vector( ybuf, 2, 1, 0 );
alpha = scalar2ndarray( new Complex64( 2.0, 2.0 ), 'complex64', 'row-major' );
alpha = scalar2ndarray( new Complex64( 2.0, 2.0 ), {
'dtype': 'complex64'
});

v = caxpy( [ x, y, alpha ] );

Expand Down Expand Up @@ -157,7 +161,9 @@ tape( 'if provided empty ndarrays, the function returns the output ndarray uncha
ybuf = new Complex64Array( [] );
x = vector( xbuf, 0, 1, 0 );
y = vector( ybuf, 0, 1, 0 );
alpha = scalar2ndarray( new Complex64( 1.0, 2.0 ), 'complex64', 'row-major' );
alpha = scalar2ndarray( new Complex64( 1.0, 2.0 ), {
'dtype': 'complex64'
});

v = caxpy( [ x, y, alpha ] );

Expand Down Expand Up @@ -204,7 +210,9 @@ tape( 'the function supports one-dimensional ndarrays having non-unit strides',
1.0
]);
y = vector( ybuf, 3, 1, 0 );
alpha = scalar2ndarray( new Complex64( 2.0, 2.0 ), 'complex64', 'row-major' );
alpha = scalar2ndarray( new Complex64( 2.0, 2.0 ), {
'dtype': 'complex64'
});

v = caxpy( [ x, y, alpha ] );

Expand Down Expand Up @@ -261,7 +269,9 @@ tape( 'the function supports one-dimensional ndarrays having negative strides',
10.0
]);
y = vector( ybuf, 3, -1, 2 );
alpha = scalar2ndarray( new Complex64( 2.0, 2.0 ), 'complex64', 'row-major' );
alpha = scalar2ndarray( new Complex64( 2.0, 2.0 ), {
'dtype': 'complex64'
});

v = caxpy( [ x, y, alpha ] );

Expand Down Expand Up @@ -330,7 +340,9 @@ tape( 'the function supports one-dimensional ndarrays having non-zero offsets',
8.0
]);
y = vector( ybuf, 4, 1, 2 );
alpha = scalar2ndarray( new Complex64( 2.0, 2.0 ), 'complex64', 'row-major' );
alpha = scalar2ndarray( new Complex64( 2.0, 2.0 ), {
'dtype': 'complex64'
});

v = caxpy( [ x, y, alpha ] );

Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/blas/base/ndarray/ccopy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ var y = new Complex64Vector( [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ] );
var z = ccopy( [ x, y ] );
// returns <ndarray>[ <Complex64>[ 1.0, 2.0 ], <Complex64>[ 3.0, 4.0 ], <Complex64>[ 5.0, 6.0 ] ]

var bool = ( y === z );
var bool = ( z === y );
// returns true
```

Expand Down
26 changes: 19 additions & 7 deletions lib/node_modules/@stdlib/blas/base/ndarray/daxpy/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
var tape = require( 'tape' );
var isSameFloat64Array = require( '@stdlib/assert/is-same-float64array' );
var Float64Array = require( '@stdlib/array/float64' );
var scalar2ndarray = require( '@stdlib/ndarray/base/from-scalar' );
var scalar2ndarray = require( '@stdlib/ndarray/from-scalar' );
var ndarray = require( '@stdlib/ndarray/base/ctor' );
var getData = require( '@stdlib/ndarray/data-buffer' );
var daxpy = require( './../lib' );
Expand Down Expand Up @@ -72,7 +72,9 @@ tape( 'the function multiplies a one-dimensional ndarray `x` by a constant `alph
ybuf = new Float64Array( [ 1.0, 1.0, 1.0, 1.0, 1.0 ] );
x = vector( xbuf, 5, 1, 0 );
y = vector( ybuf, 5, 1, 0 );
alpha = scalar2ndarray( 2.0, 'float64', 'row-major' );
alpha = scalar2ndarray( 2.0, {
'dtype': 'float64'
});

v = daxpy( [ x, y, alpha ] );

Expand All @@ -84,7 +86,9 @@ tape( 'the function multiplies a one-dimensional ndarray `x` by a constant `alph
ybuf = new Float64Array( [ 1.0, 1.0 ] );
x = vector( xbuf, 2, 1, 0 );
y = vector( ybuf, 2, 1, 0 );
alpha = scalar2ndarray( 2.0, 'float64', 'row-major' );
alpha = scalar2ndarray( 2.0, {
'dtype': 'float64'
});

v = daxpy( [ x, y, alpha ] );

Expand All @@ -108,7 +112,9 @@ tape( 'if provided empty ndarrays, the function returns the output ndarray uncha
ybuf = new Float64Array( [] );
x = vector( xbuf, 0, 1, 0 );
y = vector( ybuf, 0, 1, 0 );
alpha = scalar2ndarray( 5.0, 'float64', 'row-major' );
alpha = scalar2ndarray( 5.0, {
'dtype': 'float64'
});

v = daxpy( [ x, y, alpha ] );

Expand Down Expand Up @@ -145,7 +151,9 @@ tape( 'the function supports one-dimensional ndarrays having non-unit strides',
1.0
]);
y = vector( ybuf, 3, 1, 0 );
alpha = scalar2ndarray( 2.0, 'float64', 'row-major' );
alpha = scalar2ndarray( 2.0, {
'dtype': 'float64'
});

v = daxpy( [ x, y, alpha ] );

Expand Down Expand Up @@ -181,7 +189,9 @@ tape( 'the function supports one-dimensional ndarrays having negative strides',
10.0
]);
y = vector( ybuf, 3, -1, 2 );
alpha = scalar2ndarray( 3.0, 'float64', 'row-major' );
alpha = scalar2ndarray( 3.0, {
'dtype': 'float64'
});

v = daxpy( [ x, y, alpha ] );

Expand Down Expand Up @@ -223,7 +233,9 @@ tape( 'the function supports one-dimensional ndarrays having non-zero offsets',
8.0
]);
y = vector( ybuf, 4, 1, 2 );
alpha = scalar2ndarray( 3.0, 'float64', 'row-major' );
alpha = scalar2ndarray( 3.0, {
'dtype': 'float64'
});

v = daxpy( [ x, y, alpha ] );

Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/blas/base/ndarray/dswap/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ var z = dswap( [ x, y ] );
// x => <ndarray>[ 6.0, 7.0, 8.0, 9.0, 10.0 ]
// y => <ndarray>[ 1.0, 2.0, 3.0, 4.0, 5.0 ]

var bool = ( y === z );
var bool = ( z === y );
// returns true
```

Expand Down
26 changes: 19 additions & 7 deletions lib/node_modules/@stdlib/blas/base/ndarray/gaxpy/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

var tape = require( 'tape' );
var isSameArray = require( '@stdlib/assert/is-same-array' );
var scalar2ndarray = require( '@stdlib/ndarray/base/from-scalar' );
var scalar2ndarray = require( '@stdlib/ndarray/from-scalar' );
var ndarray = require( '@stdlib/ndarray/base/ctor' );
var getData = require( '@stdlib/ndarray/data-buffer' );
var gaxpy = require( './../lib' );
Expand Down Expand Up @@ -71,7 +71,9 @@ tape( 'the function multiplies a one-dimensional ndarray `x` by a constant `alph
ybuf = [ 1.0, 1.0, 1.0, 1.0, 1.0 ];
x = vector( xbuf, 5, 1, 0 );
y = vector( ybuf, 5, 1, 0 );
alpha = scalar2ndarray( 2.0, 'generic', 'row-major' );
alpha = scalar2ndarray( 2.0, {
'dtype': 'generic'
});

v = gaxpy( [ x, y, alpha ] );

Expand All @@ -83,7 +85,9 @@ tape( 'the function multiplies a one-dimensional ndarray `x` by a constant `alph
ybuf = [ 1.0, 1.0 ];
x = vector( xbuf, 2, 1, 0 );
y = vector( ybuf, 2, 1, 0 );
alpha = scalar2ndarray( 2.0, 'generic', 'row-major' );
alpha = scalar2ndarray( 2.0, {
'dtype': 'generic'
});

v = gaxpy( [ x, y, alpha ] );

Expand All @@ -107,7 +111,9 @@ tape( 'if provided empty ndarrays, the function returns the output ndarray uncha
ybuf = [];
x = vector( xbuf, 0, 1, 0 );
y = vector( ybuf, 0, 1, 0 );
alpha = scalar2ndarray( 5.0, 'generic', 'row-major' );
alpha = scalar2ndarray( 5.0, {
'dtype': 'generic'
});

v = gaxpy( [ x, y, alpha ] );

Expand Down Expand Up @@ -144,7 +150,9 @@ tape( 'the function supports one-dimensional ndarrays having non-unit strides',
1.0
];
y = vector( ybuf, 3, 1, 0 );
alpha = scalar2ndarray( 2.0, 'generic', 'row-major' );
alpha = scalar2ndarray( 2.0, {
'dtype': 'generic'
});

v = gaxpy( [ x, y, alpha ] );

Expand Down Expand Up @@ -180,7 +188,9 @@ tape( 'the function supports one-dimensional ndarrays having negative strides',
10.0
];
y = vector( ybuf, 3, -1, 2 );
alpha = scalar2ndarray( 3.0, 'generic', 'row-major' );
alpha = scalar2ndarray( 3.0, {
'dtype': 'generic'
});

v = gaxpy( [ x, y, alpha ] );

Expand Down Expand Up @@ -222,7 +232,9 @@ tape( 'the function supports one-dimensional ndarrays having non-zero offsets',
8.0
];
y = vector( ybuf, 4, 1, 2 );
alpha = scalar2ndarray( 3.0, 'generic', 'row-major' );
alpha = scalar2ndarray( 3.0, {
'dtype': 'generic'
});

v = gaxpy( [ x, y, alpha ] );

Expand Down
26 changes: 19 additions & 7 deletions lib/node_modules/@stdlib/blas/base/ndarray/saxpy/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
var tape = require( 'tape' );
var isSameFloat32Array = require( '@stdlib/assert/is-same-float32array' );
var Float32Array = require( '@stdlib/array/float32' );
var scalar2ndarray = require( '@stdlib/ndarray/base/from-scalar' );
var scalar2ndarray = require( '@stdlib/ndarray/from-scalar' );
var ndarray = require( '@stdlib/ndarray/base/ctor' );
var getData = require( '@stdlib/ndarray/data-buffer' );
var saxpy = require( './../lib' );
Expand Down Expand Up @@ -72,7 +72,9 @@
ybuf = new Float32Array( [ 1.0, 1.0, 1.0, 1.0, 1.0 ] );
x = vector( xbuf, 5, 1, 0 );
y = vector( ybuf, 5, 1, 0 );
alpha = scalar2ndarray( 2.0, 'float32', 'row-major' );
alpha = scalar2ndarray( 2.0, {
'dtype': 'float32'
});

v = saxpy( [ x, y, alpha ] );

Expand All @@ -84,7 +86,9 @@
ybuf = new Float32Array( [ 1.0, 1.0 ] );
x = vector( xbuf, 2, 1, 0 );
y = vector( ybuf, 2, 1, 0 );
alpha = scalar2ndarray( 2.0, 'float32', 'row-major' );
alpha = scalar2ndarray( 2.0, {
'dtype': 'float32'
});

v = saxpy( [ x, y, alpha ] );

Expand All @@ -108,7 +112,9 @@
ybuf = new Float32Array( [] );
x = vector( xbuf, 0, 1, 0 );
y = vector( ybuf, 0, 1, 0 );
alpha = scalar2ndarray( 5.0, 'float32', 'row-major' );
alpha = scalar2ndarray( 5.0, {
'dtype': 'float32'
});

v = saxpy( [ x, y, alpha ] );

Expand Down Expand Up @@ -145,7 +151,9 @@
1.0
]);
y = vector( ybuf, 3, 1, 0 );
alpha = scalar2ndarray( 2.0, 'float32', 'row-major' );
alpha = scalar2ndarray( 2.0, {
'dtype': 'float32'
});

v = saxpy( [ x, y, alpha ] );

Expand Down Expand Up @@ -181,7 +189,9 @@
10.0
]);
y = vector( ybuf, 3, -1, 2 );
alpha = scalar2ndarray( 3.0, 'float32', 'row-major' );
alpha = scalar2ndarray( 3.0, {
'dtype': 'float32'
});

v = saxpy( [ x, y, alpha ] );

Expand Down Expand Up @@ -223,11 +233,13 @@
8.0
]);
y = vector( ybuf, 4, 1, 2 );
alpha = scalar2ndarray( 3.0, 'float32', 'row-major' );
alpha = scalar2ndarray( 3.0, {
'dtype': 'float32'
});

v = saxpy( [ x, y, alpha ] );

expected = new Float32Array( [ 1.0, 2.0, 6.0, -2.0, 11.0, 18.0, 7.0, 8.0 ] );

Check warning on line 242 in lib/node_modules/@stdlib/blas/base/ndarray/saxpy/test/test.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

This line has a length of 81. Maximum allowed is 80
t.strictEqual( v, y, 'returns expected value' );
t.strictEqual( isSameFloat32Array( getData( v ), expected ), true, 'returns expected value' );
t.end();
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/blas/base/ndarray/zaxpy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ var alpha = scalar2ndarray( new Complex128( 1.0, 2.0 ), {
var z = zaxpy( [ x, y, alpha ] );
// returns <ndarray>[ <Complex128>[ -2.0, 5.0 ], <Complex128>[ -4.0, 11.0 ], <Complex128>[ -6.0, 17.0 ] ]

var bool = ( y === z );
var bool = ( z === y );
// returns true
```

Expand Down
Loading