Skip to content

fix: add suffix wrappers and replace inline NaN literal #11947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 1 commit into from
May 5, 2026
+10 −5
Merged

fix: add suffix wrappers and replace inline NaN literal #11947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/node_modules/@stdlib/stats/strided/distances/dcosine-distance/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"@stdlib/blas/base/shared",
"@stdlib/strided/base/stride2offset",
"@stdlib/stats/strided/distances/dcosine-similarity",
"@stdlib/constants/float64/nan",
"@stdlib/napi/export",
"@stdlib/napi/argv",
"@stdlib/napi/argv-int64",
Expand All @@ -62,7 +63,8 @@
"dependencies": [
"@stdlib/blas/base/shared",
"@stdlib/strided/base/stride2offset",
"@stdlib/stats/strided/distances/dcosine-similarity"
"@stdlib/stats/strided/distances/dcosine-similarity",
"@stdlib/constants/float64/nan"
]
},
{
Expand All @@ -79,7 +81,8 @@
"dependencies": [
"@stdlib/blas/base/shared",
"@stdlib/strided/base/stride2offset",
"@stdlib/stats/strided/distances/dcosine-similarity"
"@stdlib/stats/strided/distances/dcosine-similarity",
"@stdlib/constants/float64/nan"
]
},
{
Expand All @@ -96,7 +99,8 @@
"dependencies": [
"@stdlib/blas/base/shared",
"@stdlib/strided/base/stride2offset",
"@stdlib/stats/strided/distances/dcosine-similarity"
"@stdlib/stats/strided/distances/dcosine-similarity",
"@stdlib/constants/float64/nan"
]
}
]
Expand Down
5 changes: 3 additions & 2 deletions lib/node_modules/@stdlib/stats/strided/distances/dcosine-distance/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

#include "stdlib/stats/strided/distances/dcosine_distance.h"
#include "stdlib/stats/strided/distances/dcosine_similarity.h"
#include "stdlib/constants/float64/nan.h"
#include "stdlib/blas/base/shared.h"
#include "stdlib/strided/base/stride2offset.h"

Expand Down Expand Up @@ -51,7 +52,7 @@ double API_SUFFIX(stdlib_strided_dcosine_distance)( const CBLAS_INT N, const dou
*/
double API_SUFFIX(stdlib_strided_dcosine_distance_ndarray)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX, const double *Y, const CBLAS_INT strideY, const CBLAS_INT offsetY ) {
if ( N <= 0 ) {
return 0.0/0.0; // NaN
return STDLIB_CONSTANT_FLOAT64_NAN;
}
return 1.0 - stdlib_strided_dcosine_similarity_ndarray( N, X, strideX, offsetX, Y, strideY, offsetY );
return 1.0 - API_SUFFIX(stdlib_strided_dcosine_similarity_ndarray)( N, X, strideX, offsetX, Y, strideY, offsetY );
}