Skip to content

chore: resolve lint errors (#12163)#12168

Open
SMD111-git wants to merge 2 commits into
stdlib-js:developfrom
SMD111-git:patch-1
Open

chore: resolve lint errors (#12163)#12168
SMD111-git wants to merge 2 commits into
stdlib-js:developfrom
SMD111-git:patch-1

Conversation

@SMD111-git
Copy link
Copy Markdown

fix: #12163 Removed unnecessary line breaks between fixture imports.

Resolves #12163.

Description

Removed unnecessary empty lines between require() statements in:

lib/node_modules/@stdlib/math/base/tools/hermitepoly/test/test.factory.js

What is the purpose of this pull request?

image

@stdlib-js/reviewers

Removed unnecessary line breaks between fixture imports.

Signed-off-by: SMD OWAIS <111645920+SMD111-git@users.noreply.github.com>
@SMD111-git SMD111-git requested a review from a team May 17, 2026 06:33
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels May 17, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label May 17, 2026
@SMD111-git SMD111-git changed the title fix: ##12163 Clean up fixture imports in test.factory.js fix: #12163 Clean up fixture imports in test.factory.js May 17, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@SMD111-git SMD111-git marked this pull request as draft May 17, 2026 06:46
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label May 17, 2026
@SMD111-git
Copy link
Copy Markdown
Author

Hi maintainers,

I fixed the reported JavaScript linting issues in this PR. However, the workflow check Check contributing guidelines acceptance appears to be failing due to repository workflow/configuration requirements rather than code changes.

Please let me know if any contributor agreement or additional action is required from my side.

Thank you.

@SMD111-git SMD111-git marked this pull request as ready for review May 17, 2026 10:49
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 17, 2026
Copy link
Copy Markdown
Author

@SMD111-git SMD111-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi maintainers,

I fixed the reported JavaScript linting issues in this PR. However, the workflow check Check contributing guidelines acceptance appears to be failing due to repository workflow/configuration requirements rather than code changes.

Please let me know if any contributor agreement or additional action is required from my side.

Thank you.

Copy link
Copy Markdown
Contributor

@GeoDaoyu GeoDaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, I see that you have already fixed /home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/math/base/tools/hermitepoly/test/test.factory.js
There is also a file, /home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/_tools/lint/namespace-aliases/lib/resolve.js, that needs to be fixed.

@SMD111-git
Copy link
Copy Markdown
Author

image this issue is fixed . /home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/_tools/lint/namespace-aliases/lib/resolve.js

older main
image

just we need replace the out=new Array (len); with out= [ ];

@kgryte kgryte removed the Needs Review A pull request which needs code review. label May 18, 2026
@kgryte kgryte changed the title fix: #12163 Clean up fixture imports in test.factory.js chore: resolve lint errors (#12163) May 18, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 labels May 18, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@kgryte
Copy link
Copy Markdown
Member

kgryte commented May 18, 2026

@SMD111-git In order to move forward with this PR, you need to follow the guidance in #12168 (comment).

We cannot accept this PR until you have explicitly acknowledged our contributing guidelines in your PR description.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

4 participants