Skip to content

fix: update broken CMUdict link to GitHub mirror in datasets/cmudict README#12175

Open
algojogacor wants to merge 1 commit into
stdlib-js:developfrom
algojogacor:fix/broken-cmudict-link-2
Open

fix: update broken CMUdict link to GitHub mirror in datasets/cmudict README#12175
algojogacor wants to merge 1 commit into
stdlib-js:developfrom
algojogacor:fix/broken-cmudict-link-2

Conversation

@algojogacor
Copy link
Copy Markdown

Summary

Fixes #11868

The CMUdict README references http://www.speech.cs.cmu.edu/cgi-bin/cmudict#about, a legacy URL that no longer resolves (HTTP status 0 — connection failure). The CMU Pronouncing Dictionary is now maintained as part of the CMU Sphinx project on GitHub.

Root Cause

The [cmudict] reference link at the bottom of lib/node_modules/@stdlib/datasets/cmudict/README.md points to the old CMU Speech Group CGI endpoint, which has been decommissioned. The resource is permanently unavailable at that URL.

Fix

Replaced the broken URL with the canonical GitHub mirror: https://github.com/cmusphinx/cmudict. This is the official upstream repository for the CMU Pronouncing Dictionary, actively maintained by the CMU Sphinx project.

Changes

  • lib/node_modules/@stdlib/datasets/cmudict/README.md: update reference link URL (+1 -1 lines)

Testing

  • Visit the new URL: https://github.com/cmusphinx/cmudict resolves correctly and contains the dictionary data ✅
  • Old URL confirmed broken: http://www.speech.cs.cmu.edu/cgi-bin/cmudict#about still returns connection failure ✅
  • All other dataset README links: unaffected (only cmudict reference changed) ✅

@algojogacor algojogacor requested a review from a team May 17, 2026 11:18
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 17, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Potential Duplicate There might be another pull request resolving the same issue. labels May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Potential Duplicate There might be another pull request resolving the same issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix broken Markdown link: http://www.speech.cs.cmu.edu/cgi-bin/cmudict#about

2 participants