feat: add C implementation for math/base/sepcial/gammaincinv#8300
feat: add C implementation for math/base/sepcial/gammaincinv#8300rajanarahul93 wants to merge 6 commits intostdlib-js:developfrom rajanarahul93:feat-gammaincinv-c-impl-3355
math/base/sepcial/gammaincinv#8300Conversation
|
I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue". Why this matters: Required action: Thank you for your contribution to the project! |
|
@rajanarahul93 Thank you for working on this. You'll need to spend some time in getting familiar with the packages in |
math/base/sepcial/gammaincinv
|
Thanks for the feedback, @gunjjoshi. I’ll go through similar past PRs and existing math/base/special packages to better understand the structure and requirements, then update this implementation accordingly. |
|
Thank you for working on this pull request. However, we cannot accept your contribution as this pull request does not follow project conventions. We place a high value on consistency throughout the stdlib codebase, and this pull request was found to significantly deviate from stdlib conventions. We encourage you to closely examine other packages in stdlib and attempt to emulate the practices and conventions found therein.
In short, the more effort you put in to ensure that your contribution looks and feels like stdlib—including variables names, bracket spacing, line breaks, etc—the more likely that your contribution will be reviewed and ultimately accepted. We encourage you to closely study the codebase before continuing to work on this pull request. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
Progresses #3677.
Description
This pull request:
@stdlib/math/base/special/gammaincinv, including a Node-API addon, C examples, C benchmarks, native JS tests, and native JS benchmarks, fulfilling the requirements outlined in the related RFC. This implementation is a necessary prerequisite for adding a C implementation to@stdlib/stats/base/dists/invgamma/quantile.Related Issues
This pull request has the following related issues:
@stdlib/stats/base/dists/invgamma/quantile#3677 (Blocked by this PR)Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Assisted by an AI (Gemini) to generate the C code translation, Node-API boilerplate, Makefiles, tests, benchmarks, documentation updates, and Git/build commands based on the existing JavaScript implementation and stdlib conventions. Local build verification was problematic due to environment issues, but the code structure follows project patterns.
@stdlib-js/reviewers