Open
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8478
Description
This pull request implements the RFC proposing the addition of the package symbol/match.
The package is designed to match the structure and conventions used by existing symbol packages in stdlib, including:
-symbol/has-instance
-symbol/iterator
-symbol/async-iterator
-symbol/is-concat-spreadable
The primary purpose of this package is to export Symbol.match when it exists in the environment, and null otherwise.
This pull request:
-Adds the new @stdlib/symbol/match package
-Renames and adapts code from an existing symbol package template
-Ensures all references use the correct package name (match)
-Creates a variable name consistent with stdlib conventions (e.g., matchSymbol)
-Provides updated documentation, descriptions, and examples using MDN reference behavior
-Implements tests, benchmarks, and examples for the new package
-Verifies the package follows all project conventions and patterns
-Updates the copyright years to 2025
-Reviews the implementation to ensure there are no copy-paste mistakes
Related Issues
This pull request has the following related issues:
symbol/match#8478Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I used ChatGPT to assist with understanding stdlib package structure and documentation conventions.
All final code, edits, and documentation were authored manually and reviewed by me before submission.
@stdlib-js/reviewers