Skip to content

bench: refactor to use string interpolation in array/base/accessor-getter#8651

Closed
JavaTypedScript wants to merge 1 commit intostdlib-js:developfrom
JavaTypedScript:bench-refactor/string-interpolation
Closed

bench: refactor to use string interpolation in array/base/accessor-getter#8651
JavaTypedScript wants to merge 1 commit intostdlib-js:developfrom
JavaTypedScript:bench-refactor/string-interpolation

Conversation

@JavaTypedScript
Copy link
Copy Markdown
Contributor

@JavaTypedScript JavaTypedScript commented Nov 30, 2025

Resolves a part of #8647 .

Description

What is the purpose of this pull request?

This pull request:

  • Refactors the javaScript benchmark in @stdlib/array/base/accessor-getter to use @stdlib/string/format for string interpolation instead of string concatenation.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

Signed-off-by: Rohit R Bhat <bhatrr2021@gmail.com>
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Nov 30, 2025
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/base/accessor-getter $\color{green}176/176$
$color{green}+100.00%$
$\color{green}8/8$
$color{green}+100.00%$
$\color{green}4/4$
$color{green}+100.00%$
$\color{green}176/176$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@JavaTypedScript JavaTypedScript changed the title Use format function for benchmark labels bench: refactor string interpolation in array/base/accessor-getter Nov 30, 2025
@JavaTypedScript JavaTypedScript changed the title bench: refactor string interpolation in array/base/accessor-getter bench: refactor to use string interpolation in array/base/accessor-getter Nov 30, 2025
@JavaTypedScript JavaTypedScript deleted the bench-refactor/string-interpolation branch November 30, 2025 15:48
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants