Skip to content

feat: migrate utils/any-own-by to object/any-own-by#8658

Merged
kgryte merged 5 commits intostdlib-js:developfrom
Neerajpathak07:migrate/utils/any-own-by
Dec 1, 2025
Merged

feat: migrate utils/any-own-by to object/any-own-by#8658
kgryte merged 5 commits intostdlib-js:developfrom
Neerajpathak07:migrate/utils/any-own-by

Conversation

@Neerajpathak07
Copy link
Copy Markdown
Member

Resolves #6756.

Description

What is the purpose of this pull request?

This pull request:

  • migrates utils/any-own-by to object/any-own-by

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

This commit removes the `any-own-by` symbol from the `@stdlib/utils`
namespace due to a package migration.

BREAKING CHANGE: remove `any-own-by`

To migrate, users should access the same symbol via the
`@stdlib/object` namespace.

Ref: stdlib-js#6756
This commit removes `@stdlib/utils/any-own-by` in favor of
`@stdlib/object/any-own-by`.

BREAKING CHANGE: remove `utils/any-own-by`

To migrate, users should update their require/import paths to use
`@stdlib/objects/any-own-by` which provides the same API and implementation.

Ref: stdlib-js#6756
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Nov 30, 2025

Coverage Report

Package Statements Branches Functions Lines
namespace/alias2pkg $\color{green}95/95$
$color{green}+10.47%$
$\color{green}7/7$
$color{green}+0.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}95/95$
$color{green}+10.47%$
namespace $\color{red}39324/39427$
$color{red}--0.26%$
$\color{green}112/112$
$color{green}+0.00%$
$\color{red}2/11$
$color{red}--81.82%$
$\color{red}39324/39427$
$color{red}--0.26%$
namespace/pkg2alias $\color{green}100/100$
$color{green}+14.94%$
$\color{green}10/10$
$color{green}+0.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}100/100$
$color{green}+14.94%$
namespace/pkg2related $\color{green}100/100$
$color{green}+14.94%$
$\color{green}10/10$
$color{green}+0.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}100/100$
$color{green}+14.94%$
namespace/pkg2standalone $\color{green}95/95$
$color{green}+10.47%$
$\color{green}7/7$
$color{green}+0.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}95/95$
$color{green}+10.47%$
namespace/standalone2pkg $\color{green}95/95$
$color{green}+10.47%$
$\color{green}7/7$
$color{green}+0.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}95/95$
$color{green}+10.47%$
object/any-own-by $\color{green}123/123$
$color{green}+100.00%$
$\color{green}10/10$
$color{green}+100.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}123/123$
$color{green}+100.00%$
object/every-own-by $\color{green}123/123$
$color{green}+100.00%$
$\color{green}10/10$
$color{green}+100.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}123/123$
$color{green}+100.00%$
utils $\color{red}45800/62100$
$color{red}--26.25%$
$\color{red}765/809$
$color{red}--5.44%$
$\color{red}23/512$
$color{red}--95.51%$
$\color{red}45800/62100$
$color{red}--26.25%$
utils/none-own-by $\color{green}125/125$
$color{green}+14.68%$
$\color{green}10/10$
$color{green}+0.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}125/125$
$color{green}+14.68%$
utils/some-own-by $\color{green}131/131$
$color{green}+25.96%$
$\color{green}13/13$
$color{green}+0.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}131/131$
$color{green}+25.96%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07
Copy link
Copy Markdown
Member Author

Neerajpathak07 commented Nov 30, 2025

@kgryte lint is throwing error for anyInBy followed the guide and only removed the anyOwnBy it ig because anyInBy wasn't removed from the typescript declarations in the prev PR.
I was thinking of adding a PR first to fix it and then pull from it.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review November 30, 2025 16:34
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 30, 2025
@kgryte kgryte added release: Major Breaking change requiring a new major release. and removed Needs Review A pull request which needs code review. labels Dec 1, 2025
This commit removes the `anyInBy` symbol from the `@stdlib/utils`
namespace due to a package migration.

BREAKING CHANGE: remove `anyInBy`

To migrate, users should access the same symbol via the
`@stdlib/object` namespace.

Ref: stdlib-js#6756

Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Dec 1, 2025

@Neerajpathak07 The commit message:

remove: remove `any-own-by` from namespace

This commit removes the `any-own-by` symbol from the `@stdlib/utils`
namespace due to a package migration.

BREAKING CHANGE: remove `any-own-by`

To migrate, users should access the same symbol via the
`@stdlib/object` namespace.

Ref: https://github.com/stdlib-js/stdlib/issues/6756

should have been

remove: remove `anyOwnBy` from namespace

This commit removes the `anyOwnBy` symbol from the `@stdlib/utils`
namespace due to a package migration.

BREAKING CHANGE: remove `anyOwnBy`

To migrate, users should access the same symbol via the
`@stdlib/object` namespace.

Ref: https://github.com/stdlib-js/stdlib/issues/6756

The symbol name is not the same as the package name.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Dec 1, 2025

@Neerajpathak07 The commit message:

remove: remove `utils/any-own-by`

This commit removes `@stdlib/utils/any-own-by` in favor of
`@stdlib/object/any-own-by`.

BREAKING CHANGE: remove `utils/any-own-by`

To migrate, users should update their require/import paths to use
`@stdlib/objects/any-own-by` which provides the same API and implementation.

Ref: https://github.com/stdlib-js/stdlib/issues/6756

should have been

remove: remove `utils/any-own-by`

This commit removes `@stdlib/utils/any-own-by` in favor of
`@stdlib/object/any-own-by`.

BREAKING CHANGE: remove `utils/any-own-by`

To migrate, users should update their require/import paths to use
`@stdlib/object/any-own-by` which provides the same API and implementation.

Ref: https://github.com/stdlib-js/stdlib/issues/6756

Notice the "@stdlib/objects/any-own-by" typo which is incorrect in the original message, which should be "@stdlib/object/any-own-by".

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Dec 1, 2025

@Neerajpathak07 The reason for the lint error you encountered is that in your previous any-in-by PR you had failed to also update the namespace TS declaration. I went ahead and removed it in this PR. As stated in the guide, when updating the namespace, one must remove from the lib/index.js file and the docs/index.d.ts file of the namespace. That was done in this PR.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Dec 1, 2025

The CI failure does not stem from changes introduced in this PR, as such I'll go ahead and merge.

@kgryte kgryte merged commit 412d1de into stdlib-js:develop Dec 1, 2025
11 of 12 checks passed
@Neerajpathak07
Copy link
Copy Markdown
Member Author

Neerajpathak07 commented Dec 1, 2025

Yeah which is way I thought of adding another PR to fix without any breaking change as I mentioned above. Nevertheless I'll lookout for these things and proper commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: Major Breaking change requiring a new major release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: migrate utils/any-own-by to object/any-own-by

3 participants