Skip to content

chore: fix EditorConfig lint errors (issue #8699)#8717

Merged
kgryte merged 2 commits intostdlib-js:developfrom
Ankit-Trivedi-02:chore/fix-editorconfig-scaffold
Dec 3, 2025
Merged

chore: fix EditorConfig lint errors (issue #8699)#8717
kgryte merged 2 commits intostdlib-js:developfrom
Ankit-Trivedi-02:chore/fix-editorconfig-scaffold

Conversation

@Ankit-Trivedi-02
Copy link
Copy Markdown
Contributor

@Ankit-Trivedi-02 Ankit-Trivedi-02 commented Dec 2, 2025

Resolves #8699

Description

What is the purpose of this pull request?

This pull request:

  • Fixes EditorConfig linting failures detected in the automated workflow.
  • Corrects indentation errors (spaces → tabs) in:
    lib/node_modules/@stdlib/_tools/scaffold/math-strided-unary/scripts/scaffold.sh
  • Ensures the file now conforms to the project's EditorConfig rules.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • [x ] Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • [ x] Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding
  • Help in cleean typography of PR

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I am new in this open source so i used chatGPT to understand what is error then visited codebase and clarified the issue of spaces and tab then fixed it and used AI to run file i edited to check for any error then after finding that error is suceddfully fixed i create PR and took help of it better writting of Description ( Not this part ).

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Tools Issue or pull request related to project tooling. Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Dec 2, 2025
Planeshifter
Planeshifter previously approved these changes Dec 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 3, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 3, 2025
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Dec 3, 2025

PR Commit Message

chore: fix EditorConfig lint errors (issue #8699)

PR-URL: https://github.com/stdlib-js/stdlib/pull/8717
Closes: https://github.com/stdlib-js/stdlib/issues/8699

Co-authored-by: Ankit <ankittrivedi0210@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@kgryte
style: use tabs instead of spaces
0d3639e 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Dec 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Dec 3, 2025

As the CI failure does not stem from changes introduced in this PR, we can go ahead and merge.

@kgryte kgryte merged commit 546f9ba into stdlib-js:develop Dec 3, 2025
8 of 9 checks passed
nakul-krishnakumar pushed a commit to nakul-krishnakumar/stdlib that referenced this pull request Dec 3, 2025
@Ankit-Trivedi-02 @kgryte @nakul-krishnakumar
chore: fix EditorConfig lint errors
8697c69 
PR-URL: stdlib-js#8717
Closes: stdlib-js#8699
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Ankit-Trivedi-02 Ankit-Trivedi-02 deleted the chore/fix-editorconfig-scaffold branch December 3, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

@Planeshifter Planeshifter Planeshifter left review comments

Assignees

No one assigned

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Tools Issue or pull request related to project tooling.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors

4 participants

@Ankit-Trivedi-02 @stdlib-bot @kgryte @Planeshifter