Skip to content

feat: add stats/meanors#8793

Merged
kgryte merged 7 commits intostdlib-js:developfrom
Sachinn-64:feat-stats-meanors
Dec 5, 2025
Merged

feat: add stats/meanors#8793
kgryte merged 7 commits intostdlib-js:developfrom
Sachinn-64:feat-stats-meanors

Conversation

@Sachinn-64
Copy link
Copy Markdown
Member

@Sachinn-64 Sachinn-64 commented Dec 4, 2025

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • feat: add stats/meanors

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 4, 2025
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Dec 4, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/meanors $\color{green}164/164$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}0/0$
$\color{green}+0.00%$ 		$\color{green}164/164$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Dec 5, 2025
kgryte
kgryte reviewed Dec 5, 2025
View reviewed changes
@kgryte
docs: update intro
a764494 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Dec 5, 2025
View reviewed changes
@kgryte
docs: add note
23dbeec 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Dec 5, 2025
View reviewed changes
kgryte
kgryte reviewed Dec 5, 2025
View reviewed changes
@kgryte
docs: fix desc
b38c6d2 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Dec 5, 2025
View reviewed changes
@kgryte
docs: update desc
61c2a0a 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Dec 5, 2025
View reviewed changes
kgryte
kgryte requested changes Dec 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the commented examples, this PR is looking good.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Dec 5, 2025
@Sachinn-64 Sachinn-64 requested a review from kgryte December 5, 2025 09:24
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 5, 2025
kgryte
kgryte reviewed Dec 5, 2025
View reviewed changes
kgryte
kgryte reviewed Dec 5, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/meanors/examples/index.js Outdated
var meanors = require( './../lib' );

// Generate an array of random numbers:
var xbuf = uniform( 25, 0.0, 20.0 );
Copy link
Copy Markdown
Member

@kgryte kgryte Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Orthodox-64 Same comment.

Copy link
Copy Markdown
Member

@kgryte kgryte Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, for the top-level APIs, prefer using other high-level (i.e., ndarray) APIs in examples (e.g., random/uniform, blas/ext/linspace, etc).

Copy link
Copy Markdown
Member Author

@Sachinn-64 Sachinn-64 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgryte So the previous APIs already have the discrete uniform functions. Do we need to update or change that format as well?

Copy link
Copy Markdown
Member

@kgryte kgryte Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Orthodox-64 Which previous APIs? Are you referring to stats/base/ndarray or top-level stats/* packages?

Copy link
Copy Markdown
Member

@kgryte kgryte Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of the top-level stats APIs, the only ones where we effectively need to perform manual ndarray creation is for the nan* variants, as we don't have PRNGs which support ndarray creation with missing values.

Copy link
Copy Markdown
Member Author

@Sachinn-64 Sachinn-64 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The top-level stats/* packages

Copy link
Copy Markdown
Member

@kgryte kgryte Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a particular API in mind? If so, mind sharing a link?

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 5, 2025
kgryte
kgryte requested changes Dec 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left another round of comments.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Dec 5, 2025
@Sachinn-64 Sachinn-64 requested a review from kgryte December 5, 2025 09:56
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 5, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 5, 2025
kgryte
kgryte approved these changes Dec 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit d59bcf1 into stdlib-js:develop Dec 5, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sachinn-64 @stdlib-bot @kgryte