-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add doctest-annotation-spacing ESLint rule
#8842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
20b7235
feat: add `doctest-annotation-spacing` ESLint rule
Planeshifter 850c135
docs: use JavaScript code blocks in README examples
Planeshifter b79f72f
docs: update example
kgryte bfa5a50
docs: update example
kgryte 6c31fdf
chore: update wording
Planeshifter d06fc5e
chore: address PR feedback
Planeshifter 372375d
docs: remove redundant copy found in notes
kgryte f63712c
docs: update copy
kgryte d72af44
docs: update copy
kgryte 3d43a8e
docs: add missing private annotation
kgryte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
172 changes: 172 additions & 0 deletions
172
lib/node_modules/@stdlib/_tools/eslint/rules/doctest-annotation-spacing/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,172 @@ | ||
| <!-- | ||
|
|
||
| @license Apache-2.0 | ||
|
|
||
| Copyright (c) 2025 The Stdlib Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
|
|
||
| --> | ||
|
|
||
| # doctest-annotation-spacing | ||
|
|
||
| > [ESLint rule][eslint-rules] to enforce spacing in return annotations in single-line comments. | ||
|
|
||
| <section class="intro"> | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.intro --> | ||
|
|
||
| <section class="usage"> | ||
|
|
||
| ## Usage | ||
|
|
||
| ```javascript | ||
| var rule = require( '@stdlib/_tools/eslint/rules/doctest-annotation-spacing' ); | ||
| ``` | ||
|
|
||
| #### rule | ||
|
|
||
| [ESLint rule][eslint-rules] to enforce spacing in return annotations in single-line comments. The rule checks `// returns` and `// =>` annotations (including `// e.g., returns` and `// e.g., =>` variants) and ensures: | ||
|
|
||
| - Exactly 1 space between `//` and the annotation keyword | ||
| - Exactly 1 space after the annotation keyword | ||
|
|
||
| **Bad** (too many spaces after `returns`): | ||
|
|
||
| <!-- eslint-disable stdlib/doctest-annotation-spacing --> | ||
|
|
||
| ```javascript | ||
| var v = 3.14; | ||
| // returns 3.14 | ||
| ``` | ||
|
|
||
| **Bad** (no space before `=>`): | ||
|
|
||
| <!-- eslint-disable stdlib/doctest-annotation-spacing, spaced-comment --> | ||
|
|
||
| ```javascript | ||
| console.log( 'beep' ); | ||
| //=> 'beep' | ||
| ``` | ||
|
|
||
| **Bad** (too many spaces before `returns`): | ||
|
|
||
| <!-- eslint-disable stdlib/doctest-annotation-spacing, spaced-comment --> | ||
|
|
||
| ```javascript | ||
| var x = true; | ||
| // returns true | ||
| ``` | ||
|
|
||
| **Good**: | ||
|
|
||
| ```javascript | ||
| var v = 3.14; | ||
| // returns 3.14 | ||
|
|
||
| console.log( 'beep' ); | ||
| // => 'beep' | ||
| ``` | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.usage --> | ||
|
|
||
| <section class="notes"> | ||
|
|
||
| ## Notes | ||
|
|
||
| - This rule only applies to single-line comments (starting with `//`). Multi-line comments (`/* ... */`) are ignored. | ||
|
|
||
| - The rule matches the following patterns: | ||
|
|
||
| - `// returns` | ||
| - `// =>` | ||
| - `// e.g., returns` | ||
| - `// e.g., =>` | ||
|
|
||
| - The rule enforces two spacing requirements: | ||
|
|
||
| - Exactly 1 space after `//` | ||
| - Exactly 1 space after the keyword | ||
|
kgryte marked this conversation as resolved.
Outdated
|
||
|
|
||
| </section> | ||
|
|
||
| <!-- /.notes --> | ||
|
|
||
| <section class="examples"> | ||
|
|
||
| ## Examples | ||
|
|
||
| <!-- eslint no-undef: "error" --> | ||
|
|
||
| ```javascript | ||
| var Linter = require( 'eslint' ).Linter; | ||
| var rule = require( '@stdlib/_tools/eslint/rules/doctest-annotation-spacing' ); | ||
|
|
||
| var linter = new Linter(); | ||
|
|
||
| var code = [ | ||
| 'var v = foo();', | ||
| '// returns \'beep\'', | ||
| '', | ||
| 'console.log( bar() );', | ||
| '// => \'boop\'' | ||
| ].join( '\n' ); | ||
|
|
||
| linter.defineRule( 'doctest-annotation-spacing', rule ); | ||
|
|
||
| var result = linter.verify( code, { | ||
| 'rules': { | ||
| 'doctest-annotation-spacing': 'error' | ||
| } | ||
| }); | ||
| /* returns | ||
| [ | ||
| { | ||
| 'ruleId': 'doctest-annotation-spacing', | ||
| 'severity': 2, | ||
| 'message': 'Return annotation keyword `returns` should be followed by 1 space. Found 13 space(s).', | ||
| 'line': 2, | ||
| 'column': 1, | ||
| 'nodeType': null, | ||
| 'endLine': 2, | ||
| 'endColumn': 30 | ||
| } | ||
| ] | ||
| */ | ||
| ``` | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.examples --> | ||
|
|
||
| <!-- Section for related `stdlib` packages. Do not manually edit this section, as it is automatically populated. --> | ||
|
|
||
| <section class="related"> | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.related --> | ||
|
|
||
| <!-- Section for all links. Make sure to keep an empty line after the `section` element and another before the `/section` close. --> | ||
|
|
||
| <section class="links"> | ||
|
|
||
| [eslint-rules]: https://eslint.org/docs/developer-guide/working-with-rules | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.links --> | ||
55 changes: 55 additions & 0 deletions
55
lib/node_modules/@stdlib/_tools/eslint/rules/doctest-annotation-spacing/examples/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2025 The Stdlib Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| var Linter = require( 'eslint' ).Linter; | ||
| var rule = require( './../lib' ); | ||
|
|
||
| var linter = new Linter(); | ||
|
|
||
| var code = [ | ||
| 'var v = foo();', | ||
| '// returns \'beep\'', | ||
| '', | ||
| 'console.log( bar() );', | ||
| '// => \'boop\'' | ||
| ].join( '\n' ); | ||
|
|
||
| linter.defineRule( 'doctest-annotation-spacing', rule ); | ||
|
|
||
| var result = linter.verify( code, { | ||
| 'rules': { | ||
| 'doctest-annotation-spacing': 'error' | ||
| } | ||
| }); | ||
| console.log( result ); | ||
| /* => | ||
| [ | ||
| { | ||
| 'ruleId': 'doctest-annotation-spacing', | ||
| 'severity': 2, | ||
| 'message': 'Return annotation keyword `returns` should be followed by 1 space(s). Found 13 space(s).', | ||
| 'line': 2, | ||
| 'column': 1, | ||
| 'nodeType': null, | ||
| 'endLine': 2, | ||
| 'endColumn': 30 | ||
| } | ||
| ] | ||
| */ |
39 changes: 39 additions & 0 deletions
39
lib/node_modules/@stdlib/_tools/eslint/rules/doctest-annotation-spacing/lib/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2025 The Stdlib Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| /** | ||
| * ESLint rule to enforce spacing after return annotations in single-line comments. | ||
| * | ||
| * @module @stdlib/_tools/eslint/rules/doctest-annotation-spacing | ||
| * | ||
| * @example | ||
| * var rule = require( '@stdlib/_tools/eslint/rules/doctest-annotation-spacing' ); | ||
| * | ||
| * console.log( rule ); | ||
| */ | ||
|
|
||
| // MODULES // | ||
|
|
||
| var main = require( './main.js' ); | ||
|
|
||
|
|
||
| // EXPORTS // | ||
|
|
||
| module.exports = main; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.