feat: add `stats/incr/nanmpcorr2` by piyxsh31 · Pull Request #9070 · stdlib-js/stdlib

piyxsh31 · 2025-12-15T21:31:40Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: na
task: lint_c_examples status: na
task: lint_c_benchmarks status: na
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed ---

Resolves #5601.

Description

What is the purpose of this pull request?

This pull request:

Implements nanmpcorr2 which is a wrapper around mpcorr2 to compute a moving squared sample Pearson product-moment correlation coefficient incrementally, ignoring NaN values.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

[RFC]: add stats/incr/nanmpcorr2 #5601

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

stdlib-bot · 2025-12-15T21:31:52Z

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Please read our contributing guidelines if you haven't already.
For development guidance, refer to the development guide.

Next Steps

A project maintainer will approve GitHub Actions workflows for your PR.
All CI checks must pass before your submission can be fully reviewed.
You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

stdlib-bot · 2025-12-15T21:33:22Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/incr/nanmpcorr2	$\color{green}179/179$ $\color{green}+0.00%$	$\color{green}17/17$ $\color{green}+0.00%$	$\color{green}2/2$ $\color{green}+0.00%$	$\color{green}179/179$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: piyxsh31 <agrawalpiyush415@gmail.com>

piyxsh31 · 2025-12-19T17:27:35Z

@kgryte please review this pr

Planeshifter

Sorry for only now getting to looking at this PR. Implementation should delegate to base package.

Planeshifter · 2026-03-09T06:03:32Z

lib/node_modules/@stdlib/stats/incr/nanmpcorr2/lib/main.js

+var isPositiveInteger = require( '@stdlib/assert/is-positive-integer' ).isPrimitive;
+var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
+var isnan = require( '@stdlib/math/base/assert/is-nan' );
+var incrmpcorr2 = require( '@stdlib/stats/incr/mpcorr2' );
+var format = require( '@stdlib/string/format' );


This should be a thin wrapper following the established nan-wrapper pattern (cf. nanmstdev, nanmcv). Remove the manual validation (isPositiveInteger, isNumber, format imports and the argument checks) and delegate directly to incrmpcorr2 — the base package already validates everything. Only imports needed here are isnan and incrmpcorr2.

Planeshifter · 2026-03-09T06:03:35Z

lib/node_modules/@stdlib/stats/incr/nanmpcorr2/lib/main.js

+	function accumulator( x, y ) {
+		if ( arguments.length === 0 || isnan( x ) || isnan( y ) ) {
+			return acc();
+		}
+		return acc( x, y );
+	}


Bug: if called with only one argument, y is undefined and isnan(undefined) returns false, so acc(x, undefined) gets called. Need to guard on arguments.length here as well.

Planeshifter

Sorry for only now getting to looking at this PR. Implementation should delegate to base package.

piyxsh31 changed the title ~~feat: add stats/incr/nanmpcorr2~~ feat: add stats/incr/nanmpcorr2 Dec 17, 2025

stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Dec 17, 2025

Little change

17250b1

Signed-off-by: piyxsh31 <agrawalpiyush415@gmail.com>

Planeshifter reviewed Mar 9, 2026

View reviewed changes

Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 9, 2026

Planeshifter requested changes Mar 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add `stats/incr/nanmpcorr2`#9070

feat: add `stats/incr/nanmpcorr2`#9070
piyxsh31 wants to merge 2 commits intostdlib-js:developfrom
piyxsh31:add-new-package

piyxsh31 commented Dec 15, 2025

Uh oh!

stdlib-bot commented Dec 15, 2025

Uh oh!

stdlib-bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

piyxsh31 commented Dec 19, 2025

Uh oh!

Planeshifter left a comment

Uh oh!

Planeshifter Mar 9, 2026

Uh oh!

Planeshifter Mar 9, 2026

Uh oh!

Planeshifter left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

piyxsh31 commented Dec 15, 2025

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Dec 15, 2025

Getting Started

Next Steps

Running Tests Locally

Documentation Links

Uh oh!

stdlib-bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

piyxsh31 commented Dec 19, 2025

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stdlib-bot commented Dec 15, 2025 •

edited

Loading