-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add blas/ext/base/ndarray/dapx
#9220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from 3 commits
db33d47
b4175e2
25c54a9
15d54c7
78c612a
e9c2f87
9943604
d2ddfb0
a1ff182
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,126 @@ | ||||||||
| <!-- | ||||||||
|
|
||||||||
| @license Apache-2.0 | ||||||||
|
|
||||||||
| Copyright (c) 2025 The Stdlib Authors. | ||||||||
|
|
||||||||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||||||||
| you may not use this file except in compliance with the License. | ||||||||
| You may obtain a copy of the License at | ||||||||
|
|
||||||||
| http://www.apache.org/licenses/LICENSE-2.0 | ||||||||
|
|
||||||||
| Unless required by applicable law or agreed to in writing, software | ||||||||
| distributed under the License is distributed on an "AS IS" BASIS, | ||||||||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||
| See the License for the specific language governing permissions and | ||||||||
| limitations under the License. | ||||||||
|
|
||||||||
| --> | ||||||||
|
|
||||||||
| # dapx | ||||||||
|
|
||||||||
| > Add a scalar constant to each element in a double-precision floating-point ndarray. | ||||||||
|
|
||||||||
| <section class="usage"> | ||||||||
|
|
||||||||
| ## Usage | ||||||||
|
|
||||||||
| ```javascript | ||||||||
| var dapx = require( '@stdlib/blas/ext/base/ndarray/dapx' ); | ||||||||
| ``` | ||||||||
|
|
||||||||
| #### dapx( x, alpha ) | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't correct. You need to study https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/blas/ext/base/ndarray/dcusum. This comment applies to your other PRs for |
||||||||
|
|
||||||||
| Adds a scalar constant to each element in a double-precision floating-point ndarray. | ||||||||
|
|
||||||||
| ```javascript | ||||||||
| var Float64Array = require( '@stdlib/array/float64' ); | ||||||||
| var ndarray = require( '@stdlib/ndarray/ctor' ); | ||||||||
|
|
||||||||
| var xbuf = new Float64Array( [ 1.0, 2.0, 3.0, 4.0 ] ); | ||||||||
| var x = new ndarray( 'float64', xbuf, [ 4 ], [ 1 ], 0, 'row-major' ); | ||||||||
|
|
||||||||
| var out = dapx( x, 5.0 ); | ||||||||
| // returns <ndarray>[ 6.0, 7.0, 8.0, 9.0 ] | ||||||||
| ``` | ||||||||
|
|
||||||||
| The function has the following parameters: | ||||||||
|
|
||||||||
| - **x**: input ndarray. | ||||||||
| - **alpha**: scalar constant. | ||||||||
|
|
||||||||
| Note that indexing is relative to the first index. To introduce an offset, use [`ndarray`][@stdlib/ndarray/ctor] view creation. | ||||||||
|
|
||||||||
| ```javascript | ||||||||
| var Float64Array = require( '@stdlib/array/float64' ); | ||||||||
| var ndarray = require( '@stdlib/ndarray/ctor' ); | ||||||||
|
|
||||||||
| // Initial array: | ||||||||
| var xbuf = new Float64Array( [ 1.0, 2.0, 3.0, 4.0, 5.0 ] ); | ||||||||
|
|
||||||||
| // Create an ndarray view: | ||||||||
| var x = new ndarray( 'float64', xbuf, [ 3 ], [ 1 ], 2, 'row-major' ); | ||||||||
|
|
||||||||
| var out = dapx( x, 5.0 ); | ||||||||
| // returns <ndarray>[ 8.0, 9.0, 10.0 ] | ||||||||
| ``` | ||||||||
|
|
||||||||
| </section> | ||||||||
|
|
||||||||
| <!-- /.usage --> | ||||||||
|
|
||||||||
| <section class="notes"> | ||||||||
|
|
||||||||
| ## Notes | ||||||||
|
|
||||||||
| - The function **mutates** the input ndarray. | ||||||||
|
|
||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| </section> | ||||||||
|
|
||||||||
| <!-- /.notes --> | ||||||||
|
|
||||||||
| <section class="examples"> | ||||||||
|
|
||||||||
| ## Examples | ||||||||
|
|
||||||||
| <!-- eslint no-undef: "error" --> | ||||||||
|
|
||||||||
| ```javascript | ||||||||
| var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); | ||||||||
| var ndarray = require( '@stdlib/ndarray/ctor' ); | ||||||||
| var dapx = require( '@stdlib/blas/ext/base/ndarray/dapx' ); | ||||||||
|
|
||||||||
| var xbuf = discreteUniform( 10, 0, 100, { | ||||||||
| 'dtype': 'float64' | ||||||||
| }); | ||||||||
| var x = new ndarray( 'float64', xbuf, [ 10 ], [ 1 ], 0, 'row-major' ); | ||||||||
|
|
||||||||
| console.log( x.data ); | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Study other packages. Use |
||||||||
|
|
||||||||
| dapx( x, 5.0 ); | ||||||||
|
|
||||||||
| console.log( x.data ); | ||||||||
| ``` | ||||||||
|
|
||||||||
| </section> | ||||||||
|
|
||||||||
| <!-- /.examples --> | ||||||||
|
|
||||||||
| <!-- Section for related `stdlib` packages. Do not manually edit this section, as it is automatically populated. --> | ||||||||
|
|
||||||||
| <section class="related"> | ||||||||
|
|
||||||||
| </section> | ||||||||
|
|
||||||||
| <!-- /.related --> | ||||||||
|
|
||||||||
| <!-- Section for all links. Make sure to keep an empty line after the `section` element and another before the `/section` close. --> | ||||||||
|
|
||||||||
| <section class="links"> | ||||||||
|
|
||||||||
| [@stdlib/ndarray/ctor]: https://github.com/stdlib-js/ndarray-ctor | ||||||||
|
|
||||||||
| </section> | ||||||||
|
|
||||||||
| <!-- /.links --> | ||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,101 @@ | ||||||||||||||||||||
| /** | ||||||||||||||||||||
| * @license Apache-2.0 | ||||||||||||||||||||
| * | ||||||||||||||||||||
| * Copyright (c) 2025 The Stdlib Authors. | ||||||||||||||||||||
| * | ||||||||||||||||||||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||||||||||||||||||||
| * you may not use this file except in compliance with the License. | ||||||||||||||||||||
| * You may obtain a copy of the License at | ||||||||||||||||||||
| * | ||||||||||||||||||||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||||||||||||||||||||
| * | ||||||||||||||||||||
| * Unless required by applicable law or agreed to in writing, software | ||||||||||||||||||||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||||||||||||||||||||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||||||||||||||
| * See the License for the specific language governing permissions and | ||||||||||||||||||||
| * limitations under the License. | ||||||||||||||||||||
| */ | ||||||||||||||||||||
|
|
||||||||||||||||||||
| 'use strict'; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| // MODULES // | ||||||||||||||||||||
|
|
||||||||||||||||||||
| var bench = require( '@stdlib/bench' ); | ||||||||||||||||||||
| var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); | ||||||||||||||||||||
| var isnanf = require( '@stdlib/math/base/assert/is-nanf' ); | ||||||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is not clear to me why you are using a single-precision assertion package here. |
||||||||||||||||||||
| var pow = require( '@stdlib/math/base/special/pow' ); | ||||||||||||||||||||
| var ndarray = require( '@stdlib/ndarray/ctor' ); | ||||||||||||||||||||
| var pkg = require( './../package.json' ).name; | ||||||||||||||||||||
| var dapx = require( './../lib' ); | ||||||||||||||||||||
|
|
||||||||||||||||||||
|
|
||||||||||||||||||||
| // FUNCTIONS // | ||||||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Prefer parameterization to limit copy-paste mistakes in other packages. This is one reason to first do one package (e.g., |
||||||||||||||||||||
|
|
||||||||||||||||||||
| /** | ||||||||||||||||||||
| * Creates a benchmark function. | ||||||||||||||||||||
| * | ||||||||||||||||||||
| * @private | ||||||||||||||||||||
| * @param {PositiveInteger} len - array length | ||||||||||||||||||||
| * @returns {Function} benchmark function | ||||||||||||||||||||
| */ | ||||||||||||||||||||
| function createBenchmark( len ) { | ||||||||||||||||||||
| var x; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| x = new ndarray( 'float64', discreteUniform( len, -100, 100, { | ||||||||||||||||||||
| 'dtype': 'float64' | ||||||||||||||||||||
|
kgryte marked this conversation as resolved.
Outdated
|
||||||||||||||||||||
| }), [ len ], [ 1 ], 0, 'row-major' ); | ||||||||||||||||||||
|
|
||||||||||||||||||||
| return benchmark; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| /** | ||||||||||||||||||||
| * Benchmark function. | ||||||||||||||||||||
| * | ||||||||||||||||||||
| * @private | ||||||||||||||||||||
| * @param {Benchmark} b - benchmark instance | ||||||||||||||||||||
| */ | ||||||||||||||||||||
| function benchmark( b ) { | ||||||||||||||||||||
| var z; | ||||||||||||||||||||
| var i; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| b.tic(); | ||||||||||||||||||||
| for ( i = 0; i < b.iterations; i++ ) { | ||||||||||||||||||||
| z = dapx( x, 5.0 ); | ||||||||||||||||||||
| if ( isnanf( z.data[ i % len ] ) ) { | ||||||||||||||||||||
| b.fail( 'should not return NaN' ); | ||||||||||||||||||||
| } | ||||||||||||||||||||
| } | ||||||||||||||||||||
| b.toc(); | ||||||||||||||||||||
| if ( isnanf( z.data[ i % len ] ) ) { | ||||||||||||||||||||
| b.fail( 'should not return NaN' ); | ||||||||||||||||||||
| } | ||||||||||||||||||||
| b.pass( 'benchmark finished' ); | ||||||||||||||||||||
| b.end(); | ||||||||||||||||||||
| } | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
|
|
||||||||||||||||||||
| // MAIN // | ||||||||||||||||||||
|
|
||||||||||||||||||||
| /** | ||||||||||||||||||||
| * Main execution sequence. | ||||||||||||||||||||
| * | ||||||||||||||||||||
| * @private | ||||||||||||||||||||
| */ | ||||||||||||||||||||
| function main() { | ||||||||||||||||||||
| var len; | ||||||||||||||||||||
| var min; | ||||||||||||||||||||
| var max; | ||||||||||||||||||||
| var f; | ||||||||||||||||||||
| var i; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| min = 1; // 10^min | ||||||||||||||||||||
| max = 6; // 10^max | ||||||||||||||||||||
|
|
||||||||||||||||||||
| for ( i = min; i <= max; i++ ) { | ||||||||||||||||||||
| len = pow( 10, i ); | ||||||||||||||||||||
| f = createBenchmark( len ); | ||||||||||||||||||||
| bench( pkg+':len='+len, f ); | ||||||||||||||||||||
| } | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
| main(); | ||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| {{alias}}( x, alpha ) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing empty line. Study other packages. |
||
| Adds a scalar constant to each element in a double-precision floating- | ||
| point ndarray. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| x: float64ndarray | ||
| Input ndarray. | ||
|
|
||
| alpha: number | ||
| Scalar constant. | ||
|
|
||
| Returns | ||
| ------- | ||
| out: float64ndarray | ||
| Input ndarray. | ||
|
|
||
| Examples | ||
| -------- | ||
| > var xbuf = new {{alias:@stdlib/array/float64}}( [ 1.0, 2.0, 3.0, 4.0 ] ); | ||
| > var x = {{alias:@stdlib/ndarray/ctor}}( 'float64', xbuf, [ 4 ], [ 1 ], 0, 'row-major' ); | ||
| > {{alias}}( x, 5.0 ) | ||
| <ndarray>[ 6.0, 7.0, 8.0, 9.0 ] | ||
|
|
||
| See Also | ||
| -------- | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2025 The Stdlib Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| // TypeScript Version: 4.1 | ||
|
|
||
| /// <reference types="@stdlib/types"/> | ||
|
|
||
| import { float64ndarray } from '@stdlib/types/ndarray'; | ||
|
|
||
| /** | ||
| * Adds a scalar constant to each element in a double-precision floating-point ndarray. | ||
| * | ||
| * @param x - input ndarray | ||
| * @param alpha - scalar constant | ||
| * @returns input ndarray | ||
| * | ||
| * @example | ||
| * var Float64Array = require( '@stdlib/array/float64' ); | ||
| * var ndarray = require( '@stdlib/ndarray/ctor' ); | ||
| * | ||
| * var xbuf = new Float64Array( [ 1.0, 2.0, 3.0, 4.0 ] ); | ||
| * var x = new ndarray( 'float64', xbuf, [ 4 ], [ 1 ], 0, 'row-major' ); | ||
| * | ||
| * var out = dapx( x, 5.0 ); | ||
| * // returns <ndarray>[ 6.0, 7.0, 8.0, 9.0 ] | ||
| */ | ||
| declare function dapx( x: float64ndarray, alpha: number ): float64ndarray; | ||
|
|
||
|
|
||
| // EXPORTS // | ||
|
|
||
| export = dapx; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /* | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2025 The Stdlib Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import dapx = require( './index' ); | ||
|
|
||
|
|
||
| // TESTS // | ||
|
|
||
| // The function returns an ndarray... | ||
| { | ||
| const x: any = null; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is very clearly not what we want to do. |
||
| dapx( x, 5.0 ); // $ExpectType float64ndarray | ||
| } | ||
|
|
||
| // The compiler throws an error if the function is provided a first argument which is not an ndarray... | ||
| { | ||
| dapx( 123, 5.0 ); // $ExpectError | ||
| dapx( true, 5.0 ); // $ExpectError | ||
| dapx( false, 5.0 ); // $ExpectError | ||
| dapx( null, 5.0 ); // $ExpectError | ||
| dapx( undefined, 5.0 ); // $ExpectError | ||
| dapx( '5', 5.0 ); // $ExpectError | ||
| dapx( [ '1', '2' ], 5.0 ); // $ExpectError | ||
| dapx( {}, 5.0 ); // $ExpectError | ||
| dapx( ( x: number ): number => x, 5.0 ); // $ExpectError | ||
| } | ||
|
|
||
| // The compiler throws an error if the function is provided a second argument which is not a number... | ||
| { | ||
| const x: any = null; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment. |
||
| dapx( x, '5' ); // $ExpectError | ||
| dapx( x, true ); // $ExpectError | ||
| dapx( x, false ); // $ExpectError | ||
| dapx( x, null ); // $ExpectError | ||
| dapx( x, undefined ); // $ExpectError | ||
| dapx( x, [ '1' ] ); // $ExpectError | ||
| dapx( x, {} ); // $ExpectError | ||
| dapx( x, ( x: number ): number => x ); // $ExpectError | ||
| } | ||
|
|
||
| // The compiler throws an error if the function is provided an unsupported number of arguments... | ||
| { | ||
| const x: any = null; | ||
| dapx(); // $ExpectError | ||
| dapx( x ); // $ExpectError | ||
| dapx( x, 5.0, 10 ); // $ExpectError | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applies here and throughout this PR.