feat: add blas/ext/base/ssort#9697
Open
headlessNode wants to merge 6 commits intostdlib-js:developfrom
Open
Conversation
Member
Author
|
This one would first need |
Member
Author
|
Need to merge #9698 first. |
7 tasks
Member
|
/stdlib merge |
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Apr 11, 2026
lib/node_modules/@stdlib/blas/ext/base/ssort/benchmark/c/unsorted-random/benchmark.length.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Apr 11, 2026
lib/node_modules/@stdlib/blas/ext/base/ssort/benchmark/c/unsorted-random/benchmark.length.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Apr 11, 2026
lib/node_modules/@stdlib/blas/ext/base/ssort/benchmark/c/unsorted-random/benchmark.length.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Apr 11, 2026
lib/node_modules/@stdlib/blas/ext/base/ssort/examples/c/example.c
Outdated
Show resolved
Hide resolved
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Apr 11, 2026
lib/node_modules/@stdlib/blas/ext/base/ssort/benchmark/c/unsorted-random/benchmark.length.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Apr 11, 2026
lib/node_modules/@stdlib/blas/ext/base/ssort/benchmark/c/unsorted-random/benchmark.length.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Apr 11, 2026
lib/node_modules/@stdlib/blas/ext/base/ssort/benchmark/c/unsorted-random/benchmark.length.c
Outdated
Show resolved
Hide resolved
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Apr 11, 2026
|
|
||
| var bench = require( '@stdlib/bench' ); | ||
| var uniform = require( '@stdlib/random/array/uniform' ); | ||
| var isnan = require( '@stdlib/math/base/assert/is-nan' ); |
Member
There was a problem hiding this comment.
Suggested change
| var isnan = require( '@stdlib/math/base/assert/is-nan' ); | |
| var isnanf = require( '@stdlib/math/base/assert/is-nanf' ); |
Applies here and throughout this PR.
kgryte
reviewed
Apr 11, 2026
|
|
||
| // MODULES // | ||
|
|
||
| var isnan = require( '@stdlib/math/base/assert/is-nan' ); |
Member
There was a problem hiding this comment.
Suggested change
| var isnan = require( '@stdlib/math/base/assert/is-nan' ); | |
| var isnanf = require( '@stdlib/math/base/assert/is-nanf' ); |
kgryte
reviewed
Apr 11, 2026
| // MODULES // | ||
|
|
||
| var isnan = require( '@stdlib/math/base/assert/is-nan' ); | ||
| var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' ); |
Member
There was a problem hiding this comment.
Suggested change
| var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' ); | |
| var isNegativeZerof = require( '@stdlib/math/base/assert/is-negative-zerof' ); |
kgryte
reviewed
Apr 11, 2026
lib/node_modules/@stdlib/blas/ext/base/ssort/test/fixtures/num2str.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Apr 11, 2026
lib/node_modules/@stdlib/blas/ext/base/ssort/test/fixtures/num2str.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Apr 11, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Apr 11, 2026
Comment on lines
+24
to
+26
| var isnan = require( '@stdlib/math/base/assert/is-nan' ); | ||
| var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' ); | ||
| var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' ); |
Member
There was a problem hiding this comment.
Suggested change
| var isnan = require( '@stdlib/math/base/assert/is-nan' ); | |
| var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' ); | |
| var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' ); | |
| var isnanf = require( '@stdlib/math/base/assert/is-nanf' ); | |
| var isPositiveZerof = require( '@stdlib/math/base/assert/is-positive-zerof' ); | |
| var isNegativeZerof = require( '@stdlib/math/base/assert/is-negative-zerof' ); |
Use single-precision utilities throughout your test files.
kgryte
requested changes
Apr 11, 2026
Member
kgryte
left a comment
There was a problem hiding this comment.
Mainly small nits. Please be sure to use single-precision utilities for single-precision packages.
Member
|
For METR, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves stdlib-js/metr-issue-tracker#118.
Description
This pull request:
blas/ext/base/ssortRelated Issues
This pull request has the following related issues:
blas/ext/base/ssortmetr-issue-tracker#118Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers