Skip to content

feat: add C ndarray API and refactor blas/ext/base/ssorthp#9698

Merged
kgryte merged 7 commits intostdlib-js:developfrom
headlessNode:blas-ssorthp
Apr 11, 2026
Merged

feat: add C ndarray API and refactor blas/ext/base/ssorthp#9698
kgryte merged 7 commits intostdlib-js:developfrom
headlessNode:blas-ssorthp

Conversation

@headlessNode
Copy link
Copy Markdown
Member

@headlessNode headlessNode commented Jan 11, 2026

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: na
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: na
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: missing_dependencies
  • task: lint_c_examples status: missing_dependencies
  • task: lint_c_benchmarks status: missing_dependencies
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Resolves stdlib-js/metr-issue-tracker#154.

Description

What is the purpose of this pull request?

This pull request:

  • add C ndarray API and refactor blas/ext/base/ssorthp

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@headlessNode
feat: add C ndarray API and refactor blas/ext/base/ssorthp
72f5000 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Jan 11, 2026
@headlessNode headlessNode added METR Pull request associated with the METR project. Feature Issue or pull request for adding a new feature. labels Jan 11, 2026
@headlessNode
fix: apply suggestions from code review
26d41b4 
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Jan 11, 2026 •
edited
Loading

Coverage Report

No coverage information available.

@headlessNode headlessNode mentioned this pull request Jan 11, 2026
Open
7 tasks
@headlessNode headlessNode requested a review from kgryte January 11, 2026 19:07
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Jan 11, 2026

@headlessNode Always good to see if there is an existing PR: #5119. And if so, whether you should just take it over so to get it over the finish line.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Jan 11, 2026

Looks like you did additional clean-up in this PR. No need for us to go back to the previous PR now that the work has already been done.

@kgryte kgryte mentioned this pull request Jan 11, 2026
Closed
1 task
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Jan 11, 2026

Reminder to myself to give Prashant co-authorship when merging this PR.

@headlessNode
Copy link
Copy Markdown
Member Author

headlessNode commented Mar 9, 2026

@kgryte Ping

@DhruvArvindSingh DhruvArvindSingh mentioned this pull request Mar 30, 2026
Open
7 tasks
@kgryte
Merge branch 'develop' into blas-ssorthp
576c231 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 11, 2026
@kgryte
Apply suggestions from code review
6746b14 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
64e6770 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
995dc4e 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Apr 11, 2026
View reviewed changes
kgryte
kgryte reviewed Apr 11, 2026
View reviewed changes
kgryte
kgryte reviewed Apr 11, 2026
View reviewed changes
@kgryte
Apply suggestions from code review
c77af7c 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Apr 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 11, 2026

For METR,

review_time: 18 mins

@kgryte kgryte merged commit 90824dc into stdlib-js:develop Apr 11, 2026
13 checks passed
@headlessNode headlessNode deleted the blas-ssorthp branch April 12, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add C ndarray API and refactor blas/ext/base/ssorthp

3 participants

@headlessNode @stdlib-bot @kgryte