feat: add `blas/ext/base/snancusumpw` by MeKaustubh07 · Pull Request #9810 · stdlib-js/stdlib

MeKaustubh07 · 2026-01-17T20:54:10Z

Resolves #315 .

Description

What is the purpose of this pull request?

This pull request:

feat: add blas/ext/base/snancusumpw

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

RFC: add blas/ext/base/snancusumpw #315

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

stdlib-bot · 2026-01-17T20:57:05Z

Coverage Report

Package	Statements	Branches	Functions	Lines
blas/ext/base/snancusumpw	$\color{green}430/430$ $\color{green}+0.00%$	$\color{green}22/22$ $\color{green}+0.00%$	$\color{green}4/4$ $\color{green}+0.00%$	$\color{green}430/430$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Planeshifter

Thanks for your PR!

Planeshifter · 2026-01-20T04:42:17Z

+/**
+* Computes the cumulative sum of single-precision floating-point strided array elements ignoring `NaN` values and using pairwise summation.
+*/
+void API_SUFFIX( stdlib_strided_snancusumpw )( const CBLAS_INT N, const float sum, const float *X, const CBLAS_INT strideX, float *Y, const CBLAS_INT strideY );


The API_SUFFIX macro is called with spaces around the argument here and on line 39, but the rest of the codebase uses no spaces (e.g., API_SUFFIX(stdlib_strided_scusumpw)).

Suggested change

void API_SUFFIX( stdlib_strided_snancusumpw )( const CBLAS_INT N, const float sum, const float *X, const CBLAS_INT strideX, float *Y, const CBLAS_INT strideY );

void API_SUFFIX(stdlib_strided_snancusumpw)( const CBLAS_INT N, const float sum, const float *X, const CBLAS_INT strideX, float *Y, const CBLAS_INT strideY );

Planeshifter · 2026-01-20T04:42:19Z

+/**
+* Computes the cumulative sum of single-precision floating-point strided array elements ignoring `NaN` values and using pairwise summation and alternative indexing semantics.
+*/
+void API_SUFFIX( stdlib_strided_snancusumpw_ndarray )( const CBLAS_INT N, const float sum, const float *X, const CBLAS_INT strideX, const CBLAS_INT offsetX, float *Y, const CBLAS_INT strideY, const CBLAS_INT offsetY );


Same spacing issue here - should match the codebase convention with no spaces inside API_SUFFIX().

Suggested change

void API_SUFFIX( stdlib_strided_snancusumpw_ndarray )( const CBLAS_INT N, const float sum, const float *X, const CBLAS_INT strideX, const CBLAS_INT offsetX, float *Y, const CBLAS_INT strideY, const CBLAS_INT offsetY );

void API_SUFFIX(stdlib_strided_snancusumpw_ndarray)( const CBLAS_INT N, const float sum, const float *X, const CBLAS_INT strideX, const CBLAS_INT offsetX, float *Y, const CBLAS_INT strideY, const CBLAS_INT offsetY );

Planeshifter · 2026-01-20T04:42:20Z

+#include <node_api.h>
+#include "stdlib/blas/base/shared.h"
+#include "stdlib/blas/ext/base/snancusumpw.h"
+#include "stdlib/napi/argv.h"
+#include "stdlib/napi/argv_float.h"
+#include "stdlib/napi/argv_int64.h"
+#include "stdlib/napi/argv_strided_float32array.h"
+#include "stdlib/napi/export.h"


The include order here doesn't match stdlib conventions. The package's own header should come first, then stdlib dependencies, then system headers. The correct order would be:

#include "stdlib/blas/ext/base/snancusumpw.h" #include "stdlib/blas/base/shared.h" #include "stdlib/napi/export.h" #include "stdlib/napi/argv.h" #include "stdlib/napi/argv_float.h" #include "stdlib/napi/argv_int64.h" #include "stdlib/napi/argv_strided_float32array.h" #include <node_api.h>

See scusumpw/src/addon.c for reference.

Planeshifter · 2026-01-20T04:42:21Z

+	STDLIB_NAPI_ARGV_INT64( env, strideY, argv, 5 );
+	STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, strideX, argv, 2 );
+	STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, Y, N, strideY, argv, 4 );
+	API_SUFFIX( stdlib_strided_snancusumpw )( N, sum, X, strideX, Y, strideY );


Same API_SUFFIX spacing issue - no spaces inside the parentheses.

Suggested change

API_SUFFIX( stdlib_strided_snancusumpw )( N, sum, X, strideX, Y, strideY );

API_SUFFIX(stdlib_strided_snancusumpw)( N, sum, X, strideX, Y, strideY );

Planeshifter · 2026-01-20T04:42:22Z

+	STDLIB_NAPI_ARGV_INT64( env, offsetY, argv, 7 );
+	STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, strideX, argv, 2 );
+	STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, Y, N, strideY, argv, 5 );
+	API_SUFFIX( stdlib_strided_snancusumpw_ndarray )( N, sum, X, strideX, offsetX, Y, strideY, offsetY );


Same API_SUFFIX spacing issue here.

Suggested change

API_SUFFIX( stdlib_strided_snancusumpw_ndarray )( N, sum, X, strideX, offsetX, Y, strideY, offsetY );

API_SUFFIX(stdlib_strided_snancusumpw_ndarray)( N, sum, X, strideX, offsetX, Y, strideY, offsetY );

MeKaustubh07 · 2026-01-24T06:00:41Z

@Planeshifter Done with the suggested changes , Happy to address any further feedback, and I’ll apply the same updates to similar cases as needed.

feat: add blas/ext/base/snancusumpw

21736ca

stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Jan 17, 2026

MeKaustubh07 added the Feature Issue or pull request for adding a new feature. label Jan 17, 2026

MeKaustubh07 added 2 commits January 18, 2026 02:37

removed unwanted imports

39726c0

fixed paths

19ff83f

Planeshifter requested changes Jan 24, 2026

View reviewed changes

Fixed Spacing

ae4943f

MeKaustubh07 requested a review from Planeshifter January 24, 2026 06:00

MeKaustubh07 marked this pull request as draft January 27, 2026 19:49

stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 27, 2026

MeKaustubh07 marked this pull request as ready for review February 4, 2026 16:03

stdlib-bot added the Needs Review A pull request which needs code review. label Feb 4, 2026

update readme and types for c bench

7ac746d

MeKaustubh07 force-pushed the blas/snancusumpw branch from 62d0273 to 7ac746d Compare February 20, 2026 18:50

fix: add missing empty line before related comment in README

7d112ed

MeKaustubh07 marked this pull request as draft March 5, 2026 16:27

chore: cleanup

72df656

MeKaustubh07 marked this pull request as ready for review March 9, 2026 19:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add `blas/ext/base/snancusumpw`#9810

feat: add `blas/ext/base/snancusumpw`#9810
MeKaustubh07 wants to merge 7 commits intostdlib-js:developfrom
MeKaustubh07:blas/snancusumpw

MeKaustubh07 commented Jan 17, 2026 •

edited

Loading

Uh oh!

stdlib-bot commented Jan 17, 2026 •

edited

Loading

Uh oh!

Planeshifter left a comment

Uh oh!

Planeshifter Jan 20, 2026

Uh oh!

Planeshifter Jan 20, 2026

Uh oh!

Planeshifter Jan 20, 2026

Uh oh!

Planeshifter Jan 20, 2026

Uh oh!

Planeshifter Jan 20, 2026

Uh oh!

MeKaustubh07 commented Jan 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	void API_SUFFIX( stdlib_strided_snancusumpw )( const CBLAS_INT N, const float sum, const float X, const CBLAS_INT strideX, float Y, const CBLAS_INT strideY );
	void API_SUFFIX(stdlib_strided_snancusumpw)( const CBLAS_INT N, const float sum, const float X, const CBLAS_INT strideX, float Y, const CBLAS_INT strideY );

	API_SUFFIX( stdlib_strided_snancusumpw )( N, sum, X, strideX, Y, strideY );
	API_SUFFIX(stdlib_strided_snancusumpw)( N, sum, X, strideX, Y, strideY );

	API_SUFFIX( stdlib_strided_snancusumpw_ndarray )( N, sum, X, strideX, offsetX, Y, strideY, offsetY );
	API_SUFFIX(stdlib_strided_snancusumpw_ndarray)( N, sum, X, strideX, offsetX, Y, strideY, offsetY );

Uh oh!

Conversation

MeKaustubh07 commented Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

MeKaustubh07 commented Jan 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MeKaustubh07 commented Jan 17, 2026 •

edited

Loading

stdlib-bot commented Jan 17, 2026 •

edited

Loading