Sidebar search: Escape key closes search bar if sidebar has focus

Author: jorio

gitfourchette/sidebar/sidebar.py

@@ -87,6 +87,7 @@ def __init__(self, parent):
         makeWidgetShortcut(self, self.onReturnShortcut, "Return", "Enter")
         makeWidgetShortcut(self, self.onDeleteShortcut, "Delete")
         makeWidgetShortcut(self, self.onRenameShortcut, "F2")
+        makeWidgetShortcut(self, self.searchBar.hideOrBeep, "Escape")
 
     def filterIndexToNode(self, index: QModelIndex) -> SidebarNode:
         assert index.isValid()

test/test_sidebar.py

@@ -583,6 +583,11 @@ def testSidebarFilter(tempDir, mainWindow):
     # "no-parent" doesn't contain "fix", so it must be hidden
     assert not sb.indexForRef("refs/heads/no-parent").isValid()
 
+    # Hide with keyboard shortcut
+    sb.setFocus()
+    QTest.keyClick(sb, Qt.Key.Key_Escape)
+    assert not searchBar.isVisible()
+
 
 def testSidebarFilterWithFolders(tempDir, mainWindow):
     wd = unpackRepo(tempDir)