SidebarModel: Remove mustExpandAll

Author: jorio

gitfourchette/repowidget.py

@@ -232,7 +232,6 @@ def __init__(self, repoModel: RepoModel, taskRunner: RepoTaskRunner, parent: QWi
             collapseCache = repoModel.prefs.collapseCache
             if collapseCache:
                 self.sidebar.sidebarModel.collapseCache = set(collapseCache)
-                self.sidebar.sidebarModel.mustExpandAll = False
             self.sidebar.refresh(repoModel)
 
         # ----------------------------------

gitfourchette/sidebar/sidebar.py

@@ -940,14 +940,6 @@ def selectAnyRef(self, *refs: str) -> QModelIndex | None:
     def restoreExpandedItems(self):
         model = self.sidebarModel
 
-        # Upon opening a repo with no collapse information, all indices must be expanded.
-        # expandAll() can be expensive, so only do it once.
-        if model.mustExpandAll:
-            assert not model.collapseCache, "collapseCache must be empty if mustExpandAll"
-            self.expandAll()
-            model.mustExpandAll = False
-            return
-
         frontier = model.rootNode.children[:]
         while frontier:
             node = frontier.pop()

gitfourchette/sidebar/sidebarmodel.py

@@ -205,7 +205,6 @@ class SidebarModel(QAbstractItemModel):
     _cachedToolTipText: str
 
     collapseCache: set[str]
-    mustExpandAll: bool
 
     class Role:
         Ref = Qt.ItemDataRole(Qt.ItemDataRole.UserRole + 0)
@@ -225,7 +224,6 @@ def __init__(self, parent=None):
         super().__init__(parent)
 
         self.collapseCache = set()
-        self.mustExpandAll = True
 
         self.clear()