Skip to content

Commit 84961c6

Browse files
committed
Tiling: fix crash when less than 2 tiles per dim
1 parent a75279c commit 84961c6

1 file changed

Lines changed: 21 additions & 2 deletions

File tree

ggml_extend.hpp

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@ __STATIC_INLINE__ void ggml_merge_tensor_2d(struct ggml_tensor* input,
479479
for (int ix = x_skip; ix < width; ix++) {
480480
for (int k = 0; k < channels; k++) {
481481
float new_value = ggml_tensor_get_f32(input, ix, iy, k);
482-
if (overlap_x > 0 && overlap_y > 0) { // blend colors in overlapped area
482+
if (overlap_x > 0 || overlap_y > 0) { // blend colors in overlapped area
483483
float old_value = ggml_tensor_get_f32(output, x + ix, y + iy, k);
484484

485485
const float x_f_0 = (overlap_x > 0 && x > 0) ? (ix - x_skip) / float(overlap_x) : 1;
@@ -613,12 +613,31 @@ __STATIC_INLINE__ void sd_tiling(ggml_tensor* input, ggml_tensor* output, const
613613
input_tile_size = tile_size * scale;
614614
output_tile_size = tile_size;
615615
}
616-
int num_tiles_x = (input_width - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1 - tile_overlap_factor));
616+
int num_tiles_x = (input_width - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1. - tile_overlap_factor));
617617
float tile_overlap_factor_x = (float)(input_tile_size * num_tiles_x - input_width) / (float)(input_tile_size * (num_tiles_x - 1));
618+
if (num_tiles_x <= 1) {
619+
if (input_width == input_tile_size) {
620+
num_tiles_x = 1;
621+
tile_overlap_factor_x = 0;
622+
} else {
623+
num_tiles_x = 2;
624+
tile_overlap_factor_x = (2 * input_tile_size - input_width) / (float)input_tile_size;
625+
}
626+
}
618627

619628
int num_tiles_y = (input_height - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1 - tile_overlap_factor));
620629
float tile_overlap_factor_y = (float)(input_tile_size * num_tiles_y - input_height) / (float)(input_tile_size * (num_tiles_y - 1));
630+
if (num_tiles_y <= 1) {
631+
if (input_height == input_tile_size) {
632+
num_tiles_y = 1;
633+
tile_overlap_factor_y = 0;
634+
} else {
635+
num_tiles_y = 2;
636+
tile_overlap_factor_y = (2 * input_tile_size - input_height) / (float)input_tile_size;
637+
}
638+
}
621639

640+
LOG_DEBUG("num tiles : %d, %d ", num_tiles_x, num_tiles_y);
622641
LOG_DEBUG("optimal overlap : %f, %f (targeting %f)", tile_overlap_factor_x, tile_overlap_factor_y, tile_overlap_factor);
623642

624643
GGML_ASSERT(input_width % 2 == 0 && input_height % 2 == 0 && output_width % 2 == 0 && output_height % 2 == 0); // should be multiple of 2

0 commit comments

Comments
 (0)