Fix: SafeTarExtractor may silently accept truncated members when member.size metadata is incorrect - #1663
Merged
steam-bell-92 merged 1 commit intoJul 12, 2026
Conversation
…er.size metadata is incorrect
|
@Kirtan-pc is attempting to deploy a commit to the Anuj's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
🎉 Thank you for your contribution! Your Pull Request has been merged successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Summary
Fix
SafeTarExtractor._extract_file()to detect truncated file data. When a tar member's declaredsizemetadata exceeds the actual available data, the method previously broke out of the read loop silently and renamed the incomplete temp file to the target path, allowing corrupted or partially-controlled payloads to be written to disk.Changes
security/tar_safe.py_extract_file(): Replaced the silentbreakwith an explicitUnsafeTarErrorwhensrc.read()returns empty bytes beforebytes_copiedreachesmember.size. The exception propagates to the outertry/exceptblock which cleans up the temp file before re-raising.tests/test_security.pytest_truncated_file_detection: New test that creates a valid tar, truncates the file to cut off part of the data, and verifies that extraction raisesUnsafeTarError.</|DSML|parameter>
</|DSML|invoke>
</|DSML|tool_calls>
🔗 Linked Issue
Closes #1544
📋 Contribution Checklist