fix : added correct answer capture per round in Math-Quiz check_answer - #1835
Closed
tmdeveloper007 wants to merge 1 commit into
Closed
fix : added correct answer capture per round in Math-Quiz check_answer#1835tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the Anuj's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Fixed a closure bug in
games/Math-Quiz/Math-Quiz.pywhere button commands inload_questionall referenced the sameoptionvariable, causing incorrect answers to be checked on subsequent rounds. Also fixedcheck_answerto accept acorrectparameter so it uses the captured correct answer rather than the currentself.correct_answerwhich may have changed.File changed:
games/Math-Quiz/Math-Quiz.pyChanges Made
load_question: Changed button command lambda fromlambda opt=option: self.check_answer(opt)tolambda opt=option, correct=self.correct_answer: self.check_answer(opt, correct)to capture both the selected option and the correct answer for that roundcheck_answer: Added optionalcorrect=Noneparameter; when provided, uses it instead ofself.correct_answerto avoid race condition whenself.correct_answerchanges between question load and answer checkImpact it Made
Closes #1830
Note
Please assign this PR to the
tmdeveloper007account.