fix : reset index at start of each FLAMES round to prevent wrong elimination - #1836
Closed
tmdeveloper007 wants to merge 1 commit into
Closed
fix : reset index at start of each FLAMES round to prevent wrong elimination#1836tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the Anuj's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Fixed a logic bug in
games/FLAMES-Game/FLAMES-Game.pywhere the globalindexelimination counter was not reset at the start of each round. The index was only reset inside theif valid_game:block, meaning it could retain stale values across rounds.File changed:
games/FLAMES-Game/FLAMES-Game.pyChanges Made
index = 0reset at the very start of the outerwhile Truegame loop, before any input is collectedImpact it Made
Closes #1831
Note
Please assign this PR to the
tmdeveloper007account.