fix : removed undefined mesh2 references in hero-canvas.js - #1837
Closed
tmdeveloper007 wants to merge 1 commit into
Closed
fix : removed undefined mesh2 references in hero-canvas.js#1837tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the Anuj's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Removed references to undefined
mesh2variable inweb-app/js/hero-canvas.jsthat caused JavaScript ReferenceErrors when changing theme or navigating away from the page.File changed:
web-app/js/hero-canvas.jsChanges Made
if (mesh2 && typeof mesh2.onThemeChange === 'function') mesh2.onThemeChange();from theme change observer callbackif (mesh2 && typeof mesh2.destroy === 'function') mesh2.destroy();from beforeunload handlermesh1is created and used;mesh2was never definedImpact it Made
Closes #1832
Note
Please assign this PR to the
tmdeveloper007account.