fix : aligned localStorage key to recentlyViewed across modal.js and main.js - #1838
Closed
tmdeveloper007 wants to merge 1 commit into
Closed
fix : aligned localStorage key to recentlyViewed across modal.js and main.js#1838tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the Anuj's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Fixed a localStorage key mismatch in
web-app/js/modules/modal.jsandweb-app/js/main.jsthat caused the Recently Viewed feature to never display any projects.Files changed:
web-app/js/modules/modal.js,web-app/js/main.jsChanges Made
modal.js: ChangedlocalStorage.getItem("recentProjects")tolocalStorage.getItem("recentlyViewed")andlocalStorage.setItem("recentProjects", ...)tolocalStorage.setItem("recentlyViewed", ...)main.js: Made the same changes togetItem,setItem,removeItem, and debug log calls to use the consistentrecentlyViewedkeyThis aligns all recently viewed writes and reads to use the same
recentlyViewedlocalStorage key thatindex.htmlexpects.Impact it Made
Closes #1833
Note
Please assign this PR to the
tmdeveloper007account.