fix : cleaned up handle_keypress arrow key handling in 2048-Game - #1849
Closed
tmdeveloper007 wants to merge 1 commit into
Closed
fix : cleaned up handle_keypress arrow key handling in 2048-Game#1849tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
|
@tmdeveloper007 is attempting to deploy a commit to the Anuj's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Simplified and hardened the
handle_keypressmethod ingames/2048-Game/2048-Game.pyby removing the conditional.lower()call and using.get()with direct key-to-action mapping.Changes Made
event.keysym.lower() if len(event.keysym) == 1 else event.keysymconditionalevent.keysymusagemove_mapinstead of relying on.lower()transformationif key not in move_mapcheck + dict lookup to safer.get()with None checkaction()instead ofmove_map[key]()to avoid double lookupImpact it Made
Closes #1845
Note: please assign this PR to the
tmdeveloper007account.