fix : move unreachable docstring in RegistryValidator.report and fix --strict flag - #1862
Open
tmdeveloper007 wants to merge 1 commit into
Open
fix : move unreachable docstring in RegistryValidator.report and fix --strict flag#1862tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the Anuj's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
In
utils/registry_validator.py, thereport()method had two bugs:"""Print validation summary."""was placed AFTER theif json_output: returnstatement, making it an unreachable string literal instead of a proper method docstring.--strictflag only checkedvalidator.errorsto set the exit code. The intended behavior of treating warnings as errors in strict mode was dead code because thesys.exit(1 if args.strict and validator.warnings)line was unreachable.Changes Made
reportmethod.sys.exit(1 if validator.errors else (1 if args.strict and validator.warnings else 0)).Impact it Made
help()or IDE tooltips.--strictmode now correctly returns exit code 1 when warnings are present, enabling proper CI/CD integration.Closes #1857.
Note: Please assign this PR to the
tmdeveloper007account.