fix : added immediate victory detection when player wins in Minesweeper - #1880
Open
tmdeveloper007 wants to merge 1 commit into
Open
fix : added immediate victory detection when player wins in Minesweeper#1880tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
|
@tmdeveloper007 is attempting to deploy a commit to the Anuj's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Fixed the victory detection in
games/Minesweeper/minesweeper.py. The original code checkedcheck_victory()after the action but the result (game.victory) was only used in the loop condition. If the player won on their current move,game.victorybecameTruebut the loop would continue prompting for input (and the next action would overwrite victory with game_over).Changes Made
games/Minesweeper/minesweeper.py: Moved victory check to immediately display the victory banner and return fromplay_game()when a player wins, instead of waiting for the next loop iteration.Impact it Made
Players who win by revealing all non-mine cells now immediately see the victory banner and board, rather than having it overwritten by a subsequent game-over screen.
Note: Please assign this PR to the
tmdeveloper007account.