Skip to content

fix : added immediate victory detection when player wins in Minesweeper - #1880

Open
tmdeveloper007 wants to merge 1 commit into
steam-bell-92:mainfrom
tmdeveloper007:#1873
Open

fix : added immediate victory detection when player wins in Minesweeper#1880
tmdeveloper007 wants to merge 1 commit into
steam-bell-92:mainfrom
tmdeveloper007:#1873

Conversation

@tmdeveloper007

Copy link
Copy Markdown
Contributor

Summary of What Has Been Done

Fixed the victory detection in games/Minesweeper/minesweeper.py. The original code checked check_victory() after the action but the result (game.victory) was only used in the loop condition. If the player won on their current move, game.victory became True but the loop would continue prompting for input (and the next action would overwrite victory with game_over).

Changes Made

  • games/Minesweeper/minesweeper.py: Moved victory check to immediately display the victory banner and return from play_game() when a player wins, instead of waiting for the next loop iteration.

Impact it Made

Players who win by revealing all non-mine cells now immediately see the victory banner and board, rather than having it overwritten by a subsequent game-over screen.

Note: Please assign this PR to the tmdeveloper007 account.

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

@tmdeveloper007 is attempting to deploy a commit to the Anuj's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant