fix : replaced pickle with json and added context managers in Word-Building data.py - #1883
Open
tmdeveloper007 wants to merge 1 commit into
Open
fix : replaced pickle with json and added context managers in Word-Building data.py#1883tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
|
@tmdeveloper007 is attempting to deploy a commit to the Anuj's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Replaced all
pickleoperations withjsoningames/Word-Building/data.pyand added proper context managers for all file operations. Also wrapped the module-level file reading in a helper function with error handling.Changes Made
games/Word-Building/data.py:import picklewithimport json_load_words()helper function withtry/exceptand context managers_save_words()helper function with context managersDataAdding()to use the helper functions.batto.jsonfor the data file_load_words()helper instead of barepickle.load()Impact it Made
Improved security (no pickle deserialization vulnerabilities), proper resource cleanup via context managers, and safe module imports even if the data file is corrupted or missing.
Note: Please assign this PR to the
tmdeveloper007account.