tests: Address Copilot review feedback on PR #49.

Author: nedseb

tests/runner/executor.py

@@ -112,6 +112,9 @@ def run_action(action, driver_instance):
 
     if action_type == "interactive":
         # Prompt first, then call method (used for hold-button-and-read tests)
+        import sys
+        if not sys.stdin.isatty():
+            return None  # skip in non-interactive mode
         prompt = action.get("pre_prompt", "Perform action then press Enter")
         input(f"\n  [INTERACTIVE] {prompt} ")
         method_name = action["method"]

tests/runner/mpremote_bridge.py

@@ -114,6 +114,12 @@ def run_script(
         The script has access to ``i2c`` and ``dev`` variables and must
         set a ``result`` variable.  The method returns the JSON-decoded
         value of ``result``.
+
+        The script must not print anything: any additional output on
+        stdout will cause JSON parsing to fail.
+
+        When ``hardware_init`` is provided it takes precedence over
+        ``i2c_address`` for device construction.
         """
         mod = module_name or driver_name
         i2c_init = _i2c_init_code(i2c_config)
@@ -132,7 +138,9 @@ def run_script(
             f"print(json.dumps(result))"
         )
         output = self._run(code, mount_dir=self._driver_dir(driver_name))
-        return json.loads(output)
+        # Parse only the last non-empty line as JSON to ignore stray output
+        last_line = output.strip().rsplit("\n", 1)[-1]
+        return json.loads(last_line)
 
     def scan_bus(self, i2c_config):
         """Scan I2C bus and return list of addresses."""

tests/scenarios/mcp23009e.yaml

@@ -179,7 +179,7 @@ tests:
       from machine import Pin
       from time import sleep_ms, ticks_ms, ticks_diff
       led = Pin("LED_GREEN", Pin.OUT)
-      dev._send_enable_interrupt(7)
+      dev.interrupt_on_change(7, lambda l: None)
       dev.get_gpio()
       led.on()
       start = ticks_ms()
@@ -203,7 +203,7 @@ tests:
       from machine import Pin
       from time import sleep_ms, ticks_ms, ticks_diff
       led = Pin("LED_GREEN", Pin.OUT)
-      dev._send_enable_interrupt(5)
+      dev.interrupt_on_change(5, lambda l: None)
       dev.get_gpio()
       led.on()
       start = ticks_ms()
@@ -227,7 +227,7 @@ tests:
       from machine import Pin
       from time import sleep_ms, ticks_ms, ticks_diff
       led = Pin("LED_GREEN", Pin.OUT)
-      dev._send_enable_interrupt(6)
+      dev.interrupt_on_change(6, lambda l: None)
       dev.get_gpio()
       led.on()
       start = ticks_ms()
@@ -251,7 +251,7 @@ tests:
       from machine import Pin
       from time import sleep_ms, ticks_ms, ticks_diff
       led = Pin("LED_GREEN", Pin.OUT)
-      dev._send_enable_interrupt(4)
+      dev.interrupt_on_change(4, lambda l: None)
       dev.get_gpio()
       led.on()
       start = ticks_ms()