apds9960: Auto-enable sensor when reading without active mode.

Author: nedseb

lib/apds9960/apds9960/device.py

@@ -230,8 +230,24 @@ def isLightAvailable(self):
 
         return val == APDS9960_BIT_AVALID
 
+    def _ensure_light_enabled(self):
+        enable = self.getMode()
+        if not (enable & (1 << APDS9960_MODE_AMBIENT_LIGHT)) or not (enable & 1):
+            self.enableLightSensor(interrupts=False)
+            for _ in range(50):
+                if self.isLightAvailable():
+                    return
+                sleep_ms(10)
+
+    def _ensure_proximity_enabled(self):
+        enable = self.getMode()
+        if not (enable & (1 << APDS9960_MODE_PROXIMITY)) or not (enable & 1):
+            self.enableProximitySensor(interrupts=False)
+            sleep_ms(50)
+
     # reads the ambient (clear) light level as a 16-bit value
     def readAmbientLight(self):
+        self._ensure_light_enabled()
         # read value from clear channel, low byte register
         low = self._read_reg(APDS9960_REG_CDATAL)
 
@@ -242,6 +258,7 @@ def readAmbientLight(self):
 
     # reads the red light level as a 16-bit value
     def readRedLight(self):
+        self._ensure_light_enabled()
         # read value from red channel, low byte register
         low = self._read_reg(APDS9960_REG_RDATAL)
 
@@ -252,6 +269,7 @@ def readRedLight(self):
 
     # reads the green light level as a 16-bit value
     def readGreenLight(self):
+        self._ensure_light_enabled()
         # read value from green channel, low byte register
         low = self._read_reg(APDS9960_REG_GDATAL)
 
@@ -262,6 +280,7 @@ def readGreenLight(self):
 
     # reads the blue light level as a 16-bit value
     def readBlueLight(self):
+        self._ensure_light_enabled()
         # read value from blue channel, low byte register
         low = self._read_reg(APDS9960_REG_BDATAL)
 
@@ -276,6 +295,7 @@ def readBlueLight(self):
 
     # reads the proximity level as an 8-bit value
     def readProximity(self):
+        self._ensure_proximity_enabled()
         return self._read_reg(APDS9960_REG_PDATA)
 
     # *******************************************************************************

tests/scenarios/apds9960.yaml

@@ -79,6 +79,48 @@ tests:
     expect: 128
     mode: [mock]
 
+  # ----- Auto-enable -----
+
+  - name: "Ambient light readable without explicit enable"
+    action: script
+    script: |
+      dev.disableLightSensor()
+      val = dev.readAmbientLight()
+      result = isinstance(val, int)
+    expect_true: true
+    mode: [mock]
+
+  - name: "Proximity readable without explicit enable"
+    action: script
+    script: |
+      dev.disableProximitySensor()
+      val = dev.readProximity()
+      result = isinstance(val, int)
+    expect_true: true
+    mode: [mock]
+
+  - name: "Red light readable after power off"
+    action: script
+    script: |
+      dev.disablePower()
+      val = dev.readRedLight()
+      result = isinstance(val, int)
+    expect_true: true
+    mode: [mock]
+
+  - name: "No re-enable when already active"
+    action: script
+    script: |
+      dev.enableLightSensor(False)
+      i2c.clear_write_log()
+      dev.readAmbientLight()
+      log = i2c.get_write_log()
+      result = len(log) == 0
+    expect_true: true
+    mode: [mock]
+
+  # ----- Hardware -----
+
   - name: "Ambient light in plausible range"
     action: call
     method: readAmbientLight