tests: Address Copilot review on PR #100.

Author: nedseb

tests/runner/mpremote_bridge.py

@@ -49,7 +49,10 @@ def _run(self, code, mount_dir=None):
 
         result = subprocess.run(cmd, capture_output=True, text=True, timeout=30, check=False)
         if result.returncode != 0:
-            detail = result.stderr.strip() or result.stdout.strip()
+            stderr = result.stderr.strip()
+            stdout = result.stdout.strip()
+            parts = [p for p in (stderr, stdout) if p]
+            detail = "\n".join(parts) or "(no output)"
             raise RuntimeError(f"mpremote failed: {detail}")
         # mpremote mount adds "Local directory ... is mounted at /remote"
         # to stdout; filter it out and keep only the script output
@@ -161,7 +164,13 @@ def run_raw_script(self, script, mount_dir=None):
         for line in lines[:-1]:
             print(line)
         last_line = lines[-1] if lines else ""
-        return json.loads(last_line)
+        try:
+            return json.loads(last_line)
+        except json.JSONDecodeError:
+            full = "\n".join(lines)
+            raise RuntimeError(
+                f"Script did not produce valid JSON result.\nFull output:\n{full}"
+            )
 
     def scan_bus(self, i2c_config):
         """Scan I2C bus and return list of addresses."""

tests/scenarios/board_temperature_comparison.yaml

@@ -58,13 +58,13 @@ tests:
         pad = ' ' * (12 - len(name))
         print('  ' + name + pad + ': ' + str(round(t, 2)) + ' C')
 
-      # Check dedicated thermometers in plausible range
-      dedicated = [temps['HTS221'], temps['WSEN-HIDS'], temps['WSEN-PADS']]
-      all_ok = all(5.0 <= t <= 50.0 for t in dedicated)
+      # Check thermometers in plausible range (HTS221, WSEN-HIDS, WSEN-PADS)
+      thermometers = [temps['HTS221'], temps['WSEN-HIDS'], temps['WSEN-PADS']]
+      all_ok = all(5.0 <= t <= 50.0 for t in thermometers)
 
-      # Check spread between dedicated thermometers
-      spread = max(dedicated) - min(dedicated)
-      print('  Spread (dedicated): ' + str(round(spread, 2)) + ' C')
+      # Check spread between thermometers
+      spread = max(thermometers) - min(thermometers)
+      print('  Spread: ' + str(round(spread, 2)) + ' C')
 
       result = all_ok and spread < 8.0
     expect_true: true
@@ -102,6 +102,6 @@ tests:
 
   - name: "Temperature values feel correct"
     action: manual
-    prompt: "Les temperatures lues sont-elles coherentes entre elles et avec l'ambiance ?"
+    prompt: "Les températures lues sont-elles cohérentes entre elles et avec l'ambiance ?"
     expect_true: true
     mode: [hardware]