daplink_flash: Address Copilot review on PR #164.

Author: nedseb

lib/daplink_flash/daplink_flash/const.py

@@ -30,5 +30,6 @@
 # Protocol limits
 MAX_WRITE_CHUNK = const(30)
 SECTOR_SIZE = const(256)
+MAX_SECTORS = const(32768)
 FILENAME_LEN = const(8)
 EXT_LEN = const(3)

lib/daplink_flash/daplink_flash/device.py

@@ -55,7 +55,7 @@ def busy(self):
         """Return True if flash is busy."""
         return bool(self._status() & STATUS_BUSY)
 
-    def _wait_busy(self, timeout_ms=1000):
+    def _wait_busy(self, timeout_ms=30000):
         """Poll busy bit until clear. Raises OSError on timeout."""
         elapsed = 0
         while self.busy():
@@ -114,6 +114,10 @@ def write(self, data):
                 buf[i] = 0
             self.i2c.writeto(self.address, buf)
             offset += chunk_len
+        self._wait_busy()
+        err = self._error()
+        if err:
+            raise OSError("DAPLink Flash write error: 0x{:02X}".format(err))
         return length
 
     def write_line(self, text):
@@ -152,12 +156,16 @@ def read(self, length=None):
         """
         result = bytearray()
         sector = 0
-        while True:
+        while sector < MAX_SECTORS:
             data = self.read_sector(sector)
             for i in range(SECTOR_SIZE):
-                if data[i] == 0xFF:
-                    return bytes(result)
-                result.append(data[i])
-                if length is not None and len(result) >= length:
-                    return bytes(result)
+                if length is not None:
+                    result.append(data[i])
+                    if len(result) >= length:
+                        return bytes(result)
+                else:
+                    if data[i] == 0xFF:
+                        return bytes(result)
+                    result.append(data[i])
             sector += 1
+        return bytes(result)

lib/daplink_flash/examples/sensor_log.py

@@ -75,18 +75,12 @@
     hum_sum += h
     pres_sum += p
 
-    if t < temp_min:
-        temp_min = t
-    if t > temp_max:
-        temp_max = t
-    if h < hum_min:
-        hum_min = h
-    if h > hum_max:
-        hum_max = h
-    if p < pres_min:
-        pres_min = p
-    if p > pres_max:
-        pres_max = p
+    temp_min = min(temp_min, t)
+    temp_max = max(temp_max, t)
+    hum_min = min(hum_min, h)
+    hum_max = max(hum_max, h)
+    pres_min = min(pres_min, p)
+    pres_max = max(pres_max, p)
 
     count += 1