apds9960 : improve readability

Author: nedseb

lib/apds9960/apds9960/__init__.py

@@ -1,3 +1,6 @@
 from apds9960.device import APDS9960, uAPDS9960
 
-__all__ = [ 'APDS9960', 'uAPDS9960', ]
+__all__ = [
+    "APDS9960",
+    "uAPDS9960",
+]

lib/apds9960/apds9960/const.py

@@ -7,7 +7,7 @@
 APDS9960_GESTURE_SENSITIVITY_2 = 20
 
 # APDS9960 device IDs
-APDS9960_DEV_ID = [0xab, 0x9c, 0xa8, -0x55]
+APDS9960_DEV_ID = [0xAB, 0x9C, 0xA8, -0x55]
 
 # APDS9960 times
 APDS9960_TIME_FIFO_PAUSE = 0.03
@@ -21,11 +21,11 @@
 APDS9960_REG_AIHTL = 0x86
 APDS9960_REG_AIHTH = 0x87
 APDS9960_REG_PILT = 0x89
-APDS9960_REG_PIHT = 0x8b
-APDS9960_REG_PERS = 0x8c
-APDS9960_REG_CONFIG1 = 0x8d
-APDS9960_REG_PPULSE = 0x8e
-APDS9960_REG_CONTROL = 0x8f
+APDS9960_REG_PIHT = 0x8B
+APDS9960_REG_PERS = 0x8C
+APDS9960_REG_CONFIG1 = 0x8D
+APDS9960_REG_PPULSE = 0x8E
+APDS9960_REG_CONTROL = 0x8F
 APDS9960_REG_CONFIG2 = 0x90
 APDS9960_REG_ID = 0x92
 APDS9960_REG_STATUS = 0x93
@@ -35,40 +35,40 @@
 APDS9960_REG_RDATAH = 0x97
 APDS9960_REG_GDATAL = 0x98
 APDS9960_REG_GDATAH = 0x99
-APDS9960_REG_BDATAL = 0x9a
-APDS9960_REG_BDATAH = 0x9b
-APDS9960_REG_PDATA = 0x9c
-APDS9960_REG_POFFSET_UR = 0x9d
-APDS9960_REG_POFFSET_DL = 0x9e
-APDS9960_REG_CONFIG3 = 0x9f
-APDS9960_REG_GPENTH = 0xa0
-APDS9960_REG_GEXTH = 0xa1
-APDS9960_REG_GCONF1 = 0xa2
-APDS9960_REG_GCONF2 = 0xa3
-APDS9960_REG_GOFFSET_U = 0xa4
-APDS9960_REG_GOFFSET_D = 0xa5
-APDS9960_REG_GOFFSET_L = 0xa7
-APDS9960_REG_GOFFSET_R = 0xa9
-APDS9960_REG_GPULSE = 0xa6
-APDS9960_REG_GCONF3 = 0xaA
-APDS9960_REG_GCONF4 = 0xaB
-APDS9960_REG_GFLVL = 0xae
-APDS9960_REG_GSTATUS = 0xaf
-APDS9960_REG_IFORCE = 0xe4
-APDS9960_REG_PICLEAR = 0xe5
-APDS9960_REG_CICLEAR = 0xe6
-APDS9960_REG_AICLEAR = 0xe7
-APDS9960_REG_GFIFO_U = 0xfc
-APDS9960_REG_GFIFO_D = 0xfd
-APDS9960_REG_GFIFO_L = 0xfe
-APDS9960_REG_GFIFO_R = 0xff
+APDS9960_REG_BDATAL = 0x9A
+APDS9960_REG_BDATAH = 0x9B
+APDS9960_REG_PDATA = 0x9C
+APDS9960_REG_POFFSET_UR = 0x9D
+APDS9960_REG_POFFSET_DL = 0x9E
+APDS9960_REG_CONFIG3 = 0x9F
+APDS9960_REG_GPENTH = 0xA0
+APDS9960_REG_GEXTH = 0xA1
+APDS9960_REG_GCONF1 = 0xA2
+APDS9960_REG_GCONF2 = 0xA3
+APDS9960_REG_GOFFSET_U = 0xA4
+APDS9960_REG_GOFFSET_D = 0xA5
+APDS9960_REG_GOFFSET_L = 0xA7
+APDS9960_REG_GOFFSET_R = 0xA9
+APDS9960_REG_GPULSE = 0xA6
+APDS9960_REG_GCONF3 = 0xAA
+APDS9960_REG_GCONF4 = 0xAB
+APDS9960_REG_GFLVL = 0xAE
+APDS9960_REG_GSTATUS = 0xAF
+APDS9960_REG_IFORCE = 0xE4
+APDS9960_REG_PICLEAR = 0xE5
+APDS9960_REG_CICLEAR = 0xE6
+APDS9960_REG_AICLEAR = 0xE7
+APDS9960_REG_GFIFO_U = 0xFC
+APDS9960_REG_GFIFO_D = 0xFD
+APDS9960_REG_GFIFO_L = 0xFE
+APDS9960_REG_GFIFO_R = 0xFF
 
 # APDS9960 bit fields
 APDS9960_BIT_PON = 0b00000001
 APDS9960_BIT_AEN = 0b00000010
 APDS9960_BIT_PEN = 0b00000100
 APDS9960_BIT_WEN = 0b00001000
-APSD9960_BIT_AIEN =0b00010000
+APSD9960_BIT_AIEN = 0b00010000
 APDS9960_BIT_PIEN = 0b00100000
 APDS9960_BIT_GEN = 0b01000000
 APDS9960_BIT_GVALID = 0b00000001
@@ -118,7 +118,7 @@
 APDS9960_LED_BOOST_100 = 0
 APDS9960_LED_BOOST_150 = 1
 APDS9960_LED_BOOST_200 = 2
-APDS9960_LED_BOOST_300 = 3    
+APDS9960_LED_BOOST_300 = 3
 
 # Gesture wait time values
 APDS9960_GWTIME_0MS = 0
@@ -131,33 +131,33 @@
 APDS9960_GWTIME_39_2MS = 7
 
 # Default values
-APDS9960_DEFAULT_ATIME = 219                            # 103ms
-APDS9960_DEFAULT_WTIME = 246                            # 27ms
-APDS9960_DEFAULT_PROX_PPULSE = 0x87                     # 16us, 8 pulses
-APDS9960_DEFAULT_GESTURE_PPULSE = 0x89                  # 16us, 10 pulses
-APDS9960_DEFAULT_POFFSET_UR = 0                         # 0 offset
-APDS9960_DEFAULT_POFFSET_DL = 0                         # 0 offset
-APDS9960_DEFAULT_CONFIG1 = 0x60                         # No 12x wait (WTIME) factor
+APDS9960_DEFAULT_ATIME = 219  # 103ms
+APDS9960_DEFAULT_WTIME = 246  # 27ms
+APDS9960_DEFAULT_PROX_PPULSE = 0x87  # 16us, 8 pulses
+APDS9960_DEFAULT_GESTURE_PPULSE = 0x89  # 16us, 10 pulses
+APDS9960_DEFAULT_POFFSET_UR = 0  # 0 offset
+APDS9960_DEFAULT_POFFSET_DL = 0  # 0 offset
+APDS9960_DEFAULT_CONFIG1 = 0x60  # No 12x wait (WTIME)
 APDS9960_DEFAULT_LDRIVE = APDS9960_LED_DRIVE_100MA
 APDS9960_DEFAULT_PGAIN = APDS9960_PGAIN_4X
 APDS9960_DEFAULT_AGAIN = APDS9960_AGAIN_4X
-APDS9960_DEFAULT_PILT = 0                               # Low proximity threshold
-APDS9960_DEFAULT_PIHT = 50                              # High proximity threshold
-APDS9960_DEFAULT_AILT = 0xffff                          # Force interrupt for calibration
+APDS9960_DEFAULT_PILT = 0  # Low proximity threshold
+APDS9960_DEFAULT_PIHT = 50  # High proximity threshold
+APDS9960_DEFAULT_AILT = 0xFFFF  # Force interrupt for calibration
 APDS9960_DEFAULT_AIHT = 0
-APDS9960_DEFAULT_PERS = 0x11                            # 2 consecutive prox or ALS for int.
-APDS9960_DEFAULT_CONFIG2 = 0x01                         # No saturation interrupts or LED boost  
-APDS9960_DEFAULT_CONFIG3 = 0                            # Enable all photodiodes, no SAI
-APDS9960_DEFAULT_GPENTH = 40                            # Threshold for entering gesture mode
-APDS9960_DEFAULT_GEXTH = 30                             # Threshold for exiting gesture mode    
-APDS9960_DEFAULT_GCONF1 = 0x40                          # 4 gesture events for int., 1 for exit
+APDS9960_DEFAULT_PERS = 0x11  # 2 consecutive prox or ALS for int.
+APDS9960_DEFAULT_CONFIG2 = 0x01  # No saturation interrupts or LED boost
+APDS9960_DEFAULT_CONFIG3 = 0  # Enable all photodiodes, no SAI
+APDS9960_DEFAULT_GPENTH = 40  # Threshold for entering gesture mode
+APDS9960_DEFAULT_GEXTH = 30  # Threshold for exiting gesture mode
+APDS9960_DEFAULT_GCONF1 = 0x40  # 4 gesture events for int., 1 for exit
 APDS9960_DEFAULT_GGAIN = APDS9960_GGAIN_4X
 APDS9960_DEFAULT_GLDRIVE = APDS9960_LED_DRIVE_100MA
 APDS9960_DEFAULT_GWTIME = APDS9960_GWTIME_2_8MS
-APDS9960_DEFAULT_GOFFSET = 0                            # No offset scaling for gesture mode
-APDS9960_DEFAULT_GPULSE = 0xc9                          # 32us, 10 pulses
-APDS9960_DEFAULT_GCONF3 = 0                             # All photodiodes active during gesture
-APDS9960_DEFAULT_GIEN = 0                               # Disable gesture interrupts
+APDS9960_DEFAULT_GOFFSET = 0  # No offset scaling for gesture mode
+APDS9960_DEFAULT_GPULSE = 0xC9  # 32us, 10 pulses
+APDS9960_DEFAULT_GCONF3 = 0  # All photodiodes active during gesture
+APDS9960_DEFAULT_GIEN = 0  # Disable gesture interrupts
 
 # gesture directions
 APDS9960_DIR_NONE = 0
@@ -173,4 +173,4 @@
 APDS9960_STATE_NA = 0
 APDS9960_STATE_NEAR = 1
 APDS9960_STATE_FAR = 2
-APDS9960_STATE_ALL = 3
+APDS9960_STATE_ALL = 3