tests: Address Copilot review feedback on PR #55.

Author: nedseb

tests/runner/executor.py

@@ -5,6 +5,30 @@
 from pathlib import Path
 
 
+def prompt_yes_no(prompt):
+    """Prompt user and wait for a single key: Enter=yes, Escape=no.
+
+    Returns True for yes, False for no.
+    """
+    print(f"  [MANUAL] {prompt} [Entree=oui / Echap=non] ", end="", flush=True)
+    try:
+        import tty
+        import termios
+        fd = sys.stdin.fileno()
+        old = termios.tcgetattr(fd)
+        try:
+            tty.setraw(fd)
+            ch = sys.stdin.read(1)
+        finally:
+            termios.tcsetattr(fd, termios.TCSADRAIN, old)
+        print()  # newline after keypress
+        return ch in ("\r", "\n")
+    except (ImportError, OSError):
+        # Fallback for non-Unix or piped stdin
+        response = input("")
+        return response.strip().lower() in ("", "y", "yes")
+
+
 def load_driver_mock(driver_name, fake_i2c, module_name=None):
     """Load a driver using FakeI2C on CPython.
 
@@ -86,6 +110,7 @@ def cleanup_driver(driver_name, module_name=None):
             del sys.modules[mod_name]
     sys.modules.pop("machine", None)
     sys.modules.pop("micropython", None)
+    sys.modules.pop("framebuf", None)
 
 
 def run_action(action, driver_instance):
@@ -109,8 +134,7 @@ def run_action(action, driver_instance):
 
     if action_type == "manual":
         prompt = action.get("prompt", "Manual check required")
-        from tests.test_scenarios import _prompt_yes_no
-        return _prompt_yes_no(prompt)
+        return prompt_yes_no(prompt)
 
     if action_type == "interactive":
         # Prompt first, then call method (used for hold-button-and-read tests)

tests/test_scenarios.py

@@ -11,37 +11,13 @@
     check_result,
     cleanup_driver,
     load_driver_mock,
+    prompt_yes_no,
     run_action,
 )
 
 SCENARIOS_DIR = Path(__file__).parent / "scenarios"
 
 
-def _prompt_yes_no(prompt):
-    """Prompt user and wait for a single key: Enter=yes, Escape=no.
-
-    Returns True for yes, False for no.
-    """
-    import sys
-    print(f"  [MANUAL] {prompt} [Entree=oui / Echap=non] ", end="", flush=True)
-    try:
-        import tty
-        import termios
-        fd = sys.stdin.fileno()
-        old = termios.tcgetattr(fd)
-        try:
-            tty.setraw(fd)
-            ch = sys.stdin.read(1)
-        finally:
-            termios.tcsetattr(fd, termios.TCSADRAIN, old)
-        print()  # newline after keypress
-        return ch in ("\r", "\n")
-    except (ImportError, OSError):
-        # Fallback for non-Unix or piped stdin
-        response = input("")
-        return response.strip().lower() != "n"
-
-
 def _print_result(result, test):
     """Print the measured value for report capture."""
     if isinstance(result, float):
@@ -133,7 +109,7 @@ def test_scenario(scenario, test, mode, port):
                 else:
                     print(f"  {label}: {value} {unit}")
             prompt = test.get("prompt", "Manual check")
-            result = _prompt_yes_no(prompt)
+            result = prompt_yes_no(prompt)
         elif action == "call":
             result = bridge.call_method(
                 scenario["driver"],