Skip to content

Commit c9edae7

Browse files
committed
fix(bq27441): Fix Copilot review comments on temperature PR.
1 parent a4f3f76 commit c9edae7

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

lib/bq27441/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,4 +209,4 @@ mpremote mount lib/bq27441 run lib/bq27441/examples/fuel_gauge.py
209209
* Default design capacity is 650 mAh (configurable via `set_capacity()`).
210210
* Some configuration operations require entering config mode with `enter_config()`.
211211
* The device may be sealed; use `unseal()` before advanced configuration.
212-
* Temperature readings are raw register values in 0.1 K units (see conversion above).
212+
* `temperature()` returns °C by default. Use `temperature_k()` for Kelvin or `temperature_dk()` for raw decikelvin.

lib/bq27441/bq27441/device.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,8 @@ def _read_temperature_dk(self, temp_measure_type=TempMeasureType.BATTERY):
247247
return self.read_word(BQ27441_COMMAND_TEMP)
248248
elif temp_measure_type == TempMeasureType.INTERNAL_TEMP:
249249
return self.read_word(BQ27441_COMMAND_INT_TEMP)
250-
return 0
250+
else:
251+
raise ValueError("Unsupported TempMeasureType: {!r}".format(temp_measure_type))
251252

252253
def temperature(self, temp_measure_type=TempMeasureType.BATTERY):
253254
return self._read_temperature_dk(temp_measure_type) / 10.0 - 273.15

tests/scenarios/bq27441.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ tests:
101101
action: script
102102
script: |
103103
result = dev.temperature_k()
104-
expect: 298.1
104+
expect_range: [298.09, 298.11]
105105
mode: [mock]
106106

107107
- name: "Battery temperature in decikelvin"

0 commit comments

Comments
 (0)