wsen-pads: Add two-point temperature calibration.#112
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a harmonized two-point temperature calibration API to the WSEN-PADS driver and updates mock scenarios to validate calibrated temperature outputs, aligning with the calibration approach used in other drivers.
Changes:
- Introduces
_temp_gain/_temp_offsetstate plusset_temp_offset()andcalibrate_temperature()inWSEN_PADS. - Applies gain/offset calibration in both
temperature()and the temperature value returned byread(). - Tightens mock expectations and adds new mock calibration scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lib/wsen-pads/wsen_pads/device.py |
Adds calibration state + APIs; applies calibration in temperature() and read(). |
tests/scenarios/wsen_pads.yaml |
Updates mock expectations and adds scenarios for offset and two-point calibration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Addressed Copilot review:
|
|
🎉 This PR is included in version 0.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_temp_offset()andcalibrate_temperature()methods to WSEN-PADS drivertemperature()andread()methodsCloses #106
Test plan
Mock tests (CI)
python3 -m pytest tests/ -k "wsen-pads and mock" -vHardware tests (STeaMi board)
python3 -m pytest tests/ --port /dev/ttyACM0 -k "wsen-pads and hardware" -s -vruff checkpassesTest results