hts221: Add two-point temperature calibration.#115
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds two-point temperature calibration support to the HTS221 driver, consistent with the harmonized calibration interface used by other drivers (WSEN-PADS, WSEN-HIDS, LIS2MDL).
Changes:
- Renamed internal factory calibration methods to
_read_temperature_calibration()/_read_humidity_calibration()and added publicset_temp_offset()andcalibrate_temperature()methods - Applied
_temp_gain/_temp_offsetcalibration in bothtemperature()andread() - Added 3 mock test scenarios for the new calibration features
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/hts221/hts221/device.py | Renamed internal calibration methods, added gain/offset fields and public calibration API |
| tests/scenarios/hts221.yaml | Added mock test scenarios for offset, two-point calibration, and read() calibration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 0.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_temp_offset()andcalibrate_temperature()methods for two-point calibration (gain + offset)calibrate_temperature()/calibrate_humidity()to_read_temperature_calibration()/_read_humidity_calibration()to free the public name for user calibrationtemperature()andread()read()calibrationCloses #104
Test plan
Mock tests (CI)
python3 -m pytest tests/ -k "hts221 and mock" -vHardware tests (STeaMi board)
python3 -m pytest tests/ --port /dev/ttyACM0 -k "hts221 and hardware" -s -vruff checkpassesTest results