bq27441: Migrate camelCase methods to snake_case.#138
Merged
Conversation
nedseb
force-pushed
the
fix/bq27441-snake-case
branch
from
fb02618 to
2cfcf2b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Renames all camelCase methods, instance variables, and local variables in the BQ27441 driver to snake_case, as tracked in issue #133.
Changes:
- Renamed ~30 public/private methods from camelCase to snake_case (e.g.,
deviceType()→device_type()) - Renamed instance variables (
_userConfigControl→_user_config_control,_sealFlag→_seal_flag) and all local variables to snake_case - Fixed minor typos in comments (
funciton→function,bq27442→bq27441)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 0.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133
Summary
Rename all 28 camelCase methods, instance variables, and local variables to snake_case.
Methods renamed
GPOUTPolarity()gpout_polarity()setGPOUTPolarity()set_gpout_polarity()GPOUTFunction()gpout_function()setGPOUTFunction()set_gpout_function()SOC1SetThreshold()soc1_set_threshold()SOC1ClearThreshold()soc1_clear_threshold()setSOC1Thresholds()set_soc1_thresholds()SOCFSetThreshold()socf_set_threshold()SOCFClearThreshold()socf_clear_threshold()setSOCFThresholds()set_socf_thresholds()socFlag()soc_flag()socfFlag()socf_flag()sociDelta()soci_delta()setSOCIDelta()set_soci_delta()pulseGPOUT()pulse_gpout()deviceType()device_type()enterConfig()enter_config()exitConfig()exit_config()opConfig()op_config()writeOpConfig()write_op_config()softReset()soft_reset()readWord()read_word()readControlWord()read_control_word()executeControlWord()execute_control_word()blockDataControl()block_data_control()blockDataClass()block_data_class()blockDataOffset()block_data_offset()blockDataChecksum()block_data_checksum()readBlockData()read_block_data()writeBlockData()write_block_data()computeBlockChecksum()compute_block_checksum()writeBlockChecksum()write_block_checksum()readExtendedData()read_extended_data()writeExtendedData()write_extended_data()Also renamed instance variables (
_userConfigControl→_user_config_control,_sealFlag→_seal_flag) and all local variables to snake_case.No backward-compatibility aliases.
Test plan