apds9960: fix APSD/ADPS typos in constant and exception names.#20
Merged
apds9960: fix APSD/ADPS typos in constant and exception names.#20
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes APDS9960 naming typos in the apds9960 driver to align constants/exceptions with the module name and correct an exception message typo (per #14).
Changes:
- Renames
APSD9960_BIT_AIEN→APDS9960_BIT_AIENin constants. - Renames exception classes
ADPS9960InvalidDevId/ADPS9960InvalidMode→APDS9960InvalidDevId/APDS9960InvalidMode. - Updates
device.pyto raise the renamed exceptions and fixes"valied"→"valid"in the exception message.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/apds9960/apds9960/const.py | Corrects the AIEN bit constant name. |
| lib/apds9960/apds9960/exceptions.py | Corrects exception class names and fixes a message typo. |
| lib/apds9960/apds9960/device.py | Updates raised exception class references to match renamed exceptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 0.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14
Summary
const.py: renameAPSD9960_BIT_AIEN→APDS9960_BIT_AIENexceptions.py: renameADPS9960InvalidDevId→APDS9960InvalidDevId,ADPS9960InvalidMode→APDS9960InvalidMode, fix"valied"→"valid"device.py: update references to the renamed exception classesTest plan
APSD,ADPS, orvalied