Skip to content

docs: Harmonize lis2mdl README — remove emojis.#208

Merged
nedseb merged 3 commits intomainfrom
lis2mdl-harmonise-readme
Mar 23, 2026
Merged

docs: Harmonize lis2mdl README — remove emojis.#208
nedseb merged 3 commits intomainfrom
lis2mdl-harmonise-readme

Conversation

@Charly-sketch
Copy link
Copy Markdown
Contributor

Closes #195
Parents issue: #194

Remove all emojis from section titles in lib/lis2mdl/README.md.

@Charly-sketch Charly-sketch requested a review from nedseb March 20, 2026 13:56
@Charly-sketch Charly-sketch linked an issue Mar 20, 2026 that may be closed by this pull request
2 tasks
@nedseb nedseb added the documentation Improvements or additions to documentation label Mar 20, 2026
@nedseb nedseb requested a review from Copilot March 20, 2026 14:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the LIS2MDL driver README to match the repo’s documentation style by removing emojis from section headings (per issues #195 and #194).

Changes:

  • Removed emojis from all ## section titles in lib/lis2mdl/README.md without altering the surrounding content.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@nedseb nedseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut Charly,

PR simple et bien ciblée. Le diff fait exactement ce qui est demandé : retirer les emojis des titres de section. Commit message correct, bon fichier modifié, pas de changement de contenu.

Un seul point à corriger :

🟡 Les ✅ dans la section Features sont encore là

L'issue demande de retirer tous les emojis. Les titres sont corrigés, mais la section Features contient encore 9 lignes avec des ✅ :

* ✅ Full **I²C driver** for LIS2MDL
* ✅ Supports **10 / 20 / 50 / 100 Hz** output data rates
* ✅ Temperature-compensated and low-power modes
...

Ces ✅ sont des emojis (U+2705). L'issue dit "Remove all emojis" et la checklist dit "All emojis removed from section titles" — on peut interpréter "section titles" comme les ## uniquement, mais les ✅ dans les listes sont aussi hors norme par rapport aux autres README du projet (aucun autre driver n'utilise de ✅ dans ses features). Retire-les pour être cohérent.

En dehors de ça, c'est bon. Corrige les ✅ et ça sera prêt à merger.

@Charly-sketch
Copy link
Copy Markdown
Contributor Author

Deleted all Emoji's

Should be ready to merge

@nedseb nedseb merged commit 9f0762a into main Mar 23, 2026
3 checks passed
@nedseb nedseb deleted the lis2mdl-harmonise-readme branch March 23, 2026 15:37
@semantic-release-updater
Copy link
Copy Markdown

🎉 This PR is included in version 0.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Harmonize lis2mdl README — remove emojis.

3 participants