lis2mdl: Remove useless try/except around sleep_ms calls.#62
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes unnecessary try/except blocks around sleep_ms() calls in the LIS2MDL driver's soft_reset() and reboot() methods, and adds hardware-only test scenarios to verify these methods still work.
Changes:
- Remove dead
try/exceptwrappers aroundsleep_ms()insoft_reset()andreboot() - Add two hardware-only test scenarios for
soft_reset()andreboot()followed by WHO_AM_I verification
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/lis2mdl/lis2mdl/device.py | Remove try/except around sleep_ms in soft_reset and reboot |
| tests/scenarios/lis2mdl.yaml | Add hardware test scenarios for soft_reset and reboot |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 0.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try/exceptblocks aroundsleep_ms()calls insoft_reset()andreboot()methodssleep_ms()does not raise exceptions in normal operation — thetry/exceptwas dead codeCloses #59
Test plan
ruff checkpassessoft_reset()andreboot()still work correctly on the board