[SHIP-535] test needed ensure deployments cannot leak (#471)

Tests the requirements isolation of concurrent deployments.

Author: dkolas

tests/assets/packages/requirement_isolation_package.py

@@ -0,0 +1,18 @@
+from steamship.invocable import PackageService, get
+
+
+class RequirementIsolationPackage(PackageService):
+    """This package is specially designed to allow testing of requirements installation isolation. It should NOT be
+    used as a template for any development."""
+
+    @get("try_pillow")
+    def try_pillow(self) -> str:
+        import PIL
+
+        return PIL.__name__
+
+    @get("try_pandas")
+    def try_pandas(self) -> str:
+        import pandas
+
+        return pandas.__name__

tests/steamship_tests/app/integration/test_requirements_installation_isolation.py

@@ -0,0 +1,70 @@
+import json
+from typing import List
+
+import pytest
+from steamship_tests import TEST_ASSETS_PATH
+from steamship_tests.utils.deployables import zip_deployable
+
+from steamship import Package, PackageInstance, PackageVersion, Steamship, SteamshipError
+from steamship.data.package.package_version import CreatePackageVersionRequest
+from steamship.utils.url import Verb
+
+
+@pytest.mark.usefixtures("client")
+def test_install_two_packages_at_once(client: Steamship):
+
+    pillow_version_task = create_version(client, additional_requirements=["pillow"])
+    pandas_version_task = create_version(client, additional_requirements=["pandas"])
+
+    pillow_version = pillow_version_task.wait()
+    pandas_version = pandas_version_task.wait()
+
+    pillow_instance = PackageInstance.create(
+        client, package_id=pillow_version.package_id, package_version_id=pillow_version.id
+    )
+    pandas_instance = PackageInstance.create(
+        client, package_id=pandas_version.package_id, package_version_id=pandas_version.id
+    )
+
+    # Pillow version should be able to run the method that imports pillow locally
+    assert pillow_instance.invoke("try_pillow", verb=Verb.GET) == "PIL"
+
+    # Pillow version should NOT be able to run the method that imports pandas locally
+    with pytest.raises(SteamshipError):
+        _ = pillow_instance.invoke("try_pandas", verb=Verb.GET)
+
+    # Pandas version should be able to run the method that imports pandas locally
+    assert pandas_instance.invoke("try_pandas", verb=Verb.GET) == "pandas"
+
+    # Pandas version should NOT be able to run the method that imports pillow locally
+    with pytest.raises(SteamshipError):
+        _ = pandas_instance.invoke("try_pillow", verb=Verb.GET)
+
+    pillow_version.delete()
+    pandas_version.delete()
+
+
+def create_version(client: Steamship, additional_requirements: List[str]):
+    """Separate implementation of create version so that we can not wait on the task, and run multiple at once."""
+    package = Package.create(client)
+
+    zip_bytes = zip_deployable(
+        TEST_ASSETS_PATH / "packages" / "requirement_isolation_package.py",
+        additional_requirements=additional_requirements,
+    )
+    hosting_handler = "steamship.invocable.entrypoint.safe_handler"
+
+    req = CreatePackageVersionRequest(
+        handle="handle",
+        package_id=package.id,
+        config_template=json.dumps({}),
+        hosting_handler=hosting_handler,
+    )
+
+    task = client.post(
+        "package/version/create",
+        payload=req,
+        file=("package.zip", zip_bytes, "multipart/form-data"),
+        expect=PackageVersion,
+    )
+    return task

tests/steamship_tests/utils/deployables.py

@@ -3,7 +3,7 @@
 import os
 import zipfile
 from pathlib import Path
-from typing import Any, Dict, Optional
+from typing import Any, Dict, List, Optional
 
 from steamship_tests import ROOT_PATH, SRC_PATH, TEST_ASSETS_PATH
 
@@ -14,7 +14,7 @@
 from steamship.data.user import User
 
 
-def zip_deployable(file_path: Path) -> bytes:
+def zip_deployable(file_path: Path, additional_requirements: Optional[List[str]] = None) -> bytes:
     """Prepare and zip a Steamship plugin."""
 
     package_paths = [
@@ -33,7 +33,13 @@ def zip_deployable(file_path: Path) -> bytes:
                 for file in files:
                     pypi_file = Path(root) / file
                     zip_file.write(pypi_file, pypi_file.relative_to(package_path.parent))
-        zip_file.write(ROOT_PATH / "requirements.txt", "requirements.txt")
+        if additional_requirements is None:
+            zip_file.write(ROOT_PATH / "requirements.txt", "requirements.txt")
+        else:
+            with open(ROOT_PATH / "requirements.txt", "r") as file:
+                requirements_string = file.read()
+            requirements_string += "\n" + "\n".join(additional_requirements)
+            zip_file.writestr("requirements.txt", requirements_string)
 
         # Now we'll copy in the whole assets directory so that our test files can access things there..
         for root, _, files in os.walk(TEST_ASSETS_PATH):