more debug info for trunstile; remove tron_data

Author: ety001

helpers/services.js

@@ -194,24 +194,54 @@ async function verifyCaptcha(turnstileToken, ip) {
     if (DEBUG_MODE) {
         logger.warn('Verify captcha for %s', ip);
     } else {
+        if (!turnstileSecret || turnstileSecret.trim() === '') {
+            logger.error('TURNSTILE_SECRET is not configured');
+            throw new Error('Turnstile secret key is not configured');
+        }
+
+        if (!turnstileToken || turnstileToken.trim() === '') {
+            throw new Error('Turnstile token is required');
+        }
+
         const url = `https://challenges.cloudflare.com/turnstile/v0/siteverify`;
         const formData = `secret=${encodeURIComponent(
             turnstileSecret
         )}&response=${encodeURIComponent(
             turnstileToken
         )}&remoteip=${encodeURIComponent(ip)}`;
 
-        const response = await (await fetch(url, {
-            method: 'POST',
-            headers: {
-                'Content-Type': 'application/x-www-form-urlencoded',
-            },
-            body: formData,
-        })).json();
+        let response;
+        try {
+            const fetchResponse = await fetch(url, {
+                method: 'POST',
+                headers: {
+                    'Content-Type': 'application/x-www-form-urlencoded',
+                },
+                body: formData,
+            });
+            response = await fetchResponse.json();
+        } catch (error) {
+            logger.error({ error }, 'Failed to verify Turnstile token');
+            throw new Error('Failed to verify Turnstile token');
+        }
 
         if (!response.success) {
             const errors = response['error-codes'] || ['unknown'];
-            throw new Error(`Turnstile verification failed: ${errors.join()}`);
+            logger.warn(
+                { errorCodes: errors, ip },
+                'Turnstile verification failed'
+            );
+
+            // Provide more specific error messages
+            if (errors.includes('invalid-input-secret')) {
+                throw new Error(
+                    'Turnstile verification failed: Invalid secret key. Please check TURNSTILE_SECRET configuration.'
+                );
+            }
+
+            throw new Error(
+                `Turnstile verification failed: ${errors.join(', ')}`
+            );
         }
     }
 }

routes/apiHandlers.js

@@ -1763,7 +1763,6 @@ async function handleCreateAccountNew(req) {
         xref,
         locale,
         activityTags,
-        tron_bind_data,
         source, // format: app|tag (eg. condenser|submit_post)
     } = req.body; // eslint-disable-line camelcase
 
@@ -1776,11 +1775,6 @@ async function handleCreateAccountNew(req) {
         throw new ApiError({ type: 'error_api_token_required' });
     }
 
-    if (!tron_bind_data) {
-        throw new ApiError({ type: 'error_api_tron_bind_data_required' });
-    }
-    const tronBindData = JSON.parse(tron_bind_data);
-
     let decoded;
 
     try {
@@ -1907,27 +1901,6 @@ async function handleCreateAccountNew(req) {
         });
     }
 
-    try {
-        const updateTronUserResult = await updateTronUser(
-            decoded.username,
-            tronBindData
-        );
-        req.log.info(
-            { decoded, updateTronUserResult },
-            'bind_tron_address_success'
-        );
-    } catch (cause) {
-        req.log.error(
-            { decoded, tronBindData, cause },
-            'error_api_bind_tron_addr_failed'
-        );
-        throw new ApiError({
-            type: 'error_api_bind_tron_addr_failed',
-            cause,
-            status: 500,
-        });
-    }
-
     // try {
     //     await services.gatekeeperMarkSignupCreated(user);
     // } catch (error) {