Add mTLS support#3
Merged
Merged
Conversation
Owner
|
fixed #1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive support for TLS (including mutual TLS) in the CI pipeline and the
FluvioWriterplugin initialization. The main focus is to ensure secure communication when interacting with Fluvio by configuring and testing TLS parameters both in automated workflows and at runtime, while maintaining backward compatibility for non-TLS environments.CI/CD and TLS Integration:
.github/workflows/ci-tls.yml) that sets up a full end-to-end CI pipeline for testing the Zeek plugin with TLS/mTLS enabled Fluvio clusters. This includes generating certificates, starting a Fluvio cluster with TLS, and running integration tests.Plugin Runtime TLS Configuration:
FluvioWriter::DoInitinsrc/FluvioWriter.ccto dynamically detect TLS configuration from environment variables (FLUVIO_TLS_DOMAIN,FLUVIO_TLS_KEY,FLUVIO_TLS_CERT,FLUVIO_TLS_CA). If present, the plugin configures strict mTLS; otherwise, it falls back to a non-TLS connection, improving flexibility and security.