WIP: add meson build system#1048
Conversation
|
@stefanberger any idea what might be wrong? |
|
Is this supported? |
bbb613d to
8e1a950
Compare
yes, this was related, it was was defining it with extra quotes. thanks! |
20ad361 to
46b09ab
Compare
| scripts = find_shell_scripts(directory) | ||
| for script in scripts: | ||
| script_dir = os.path.dirname(script) | ||
| cmd = ["shellcheck"] + os.environ.get('SHELLCHECK_ARGS', '').split() + [os.path.basename(script)] |
There was a problem hiding this comment.
I would expect errors from this because shellcheck needs to sometimes see source'd scripts as well. Therefore, collecting all of them in a command line and invoking shellcheck once with all of them would probably lead to better results.
There was a problem hiding this comment.
-x does that. Passing the file list from meson is tricky, because it doesn't change cwd and use absolute paths. Trying to split the run_target() in the various directories is also complicated, because you can't make dependencies between them.. I found this trade-off, seems to pass (and also run on previously unchecked scripts)
| */ | ||
|
|
||
| #include "config.h" | ||
|
|
There was a problem hiding this comment.
split off in separate patch?
| #include <stdlib.h> | ||
| #include <stdio.h> | ||
| #include <errno.h> | ||
| #include <string.h> |
There was a problem hiding this comment.
split off in separate patch?
I used Claude Code for the initial project scaffolding, but it struggled with tests and SELinux (and I struggled too, I even went down the rabbit hole and worked on proper SELinux integration in meson, although perhaps I need to revise my approach) Obviously testing/reviewing required. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
I used Claude Code for the initial project scaffolding, but it struggled with tests and SELinux (and I struggled too, I even went down the rabbit hole and worked on proper SELinux integration in meson, although perhaps I need to revise my approach)
There is still some tests failing. Obviously testing/reviewing required.
TODO: installed-tests