Skip to content

Prevent duplicate attributes #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeffBuckles wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prevent duplicate attributes #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2c6e53
Avoid duplicate words in space-delimited control attribute values
JeffBuckles May 26, 2016
8325209
Remove trailing newline from edited Control.php
JeffBuckles May 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions includes/Control.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,10 +617,20 @@ function set_attributes($attributes, $overwrite = true)
// if the value is to be appended to the already existing one
// and there is a value set for the specified attribute
// and the values do not represent an array
if (!$overwrite && isset($this->attributes[$attribute]) && !is_array($this->attributes[$attribute]))
if (!$overwrite && isset($this->attributes[$attribute]) && !is_array($this->attributes[$attribute])) {

// Check each word individually for duplication
// I think we can get away with this since added values are delimted by spaces
foreach(preg_split("/\s+/", $value) as $sub_value) {

// confirm the new value is not already present in the attribute
if ( preg_match("/(^|\s)" . $sub_value . "(\s|$)/", $this->attributes[$attribute]) === 0 )

// append the value
$this->attributes[$attribute] = $this->attributes[$attribute] . ' ' . $value;
$this->attributes[$attribute] = $this->attributes[$attribute] . ' ' . $sub_value;
}

}

// otherwise, add attribute to attributes array
else $this->attributes[$attribute] = $value;
Expand Down