Fix: Only create mismatch directory when files are actually written#5
Merged
Conversation
Contributor
Author
|
@mortenvp 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: mortenvp <1279584+mortenvp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Only create mismatch directory when needed
Fix: Only create mismatch directory when files are actually written
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The datarecorder was creating mismatch directories even when no mismatch files needed to be written, resulting in empty folders accumulating on CI systems.
Problem
The
determine_mismatch_dir()function immediately created a directory in/tmp/cppmismatch-N/whenever a mismatch was detected, regardless of whether any files would actually be written to it. This meant that:Solution
Split the directory path determination from directory creation:
determine_mismatch_dir()todetermine_mismatch_path()- now only returns the path without creating directorieswrite_data()with lazy directory creation - automatically creates parent directories when files are actually written usingstd::filesystem::create_directories()Example
Before this fix:
After this fix:
This ensures mismatch directories are created only when they actually contain files, eliminating the accumulation of empty directories on CI systems.
Fixes #4.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.