Refactor status bar with native AppKit implementation and visual indicators

Replace simple text-based menu bar display with a sophisticated native macOS
status bar implementation featuring the CodeLooper logo and colored process
count badges. This overhaul improves visual feedback, fixes duplicate settings
window issues, and provides a more professional appearance that better aligns
with macOS design patterns.

- Implement StatusBarController using NSStatusItem for native menu bar integration
- Add StatusIndicators component with CodeLooper logo and colored badges
- Create custom popover with NSVisualEffectView for proper macOS appearance
- Fix duplicate settings windows by removing SwiftUI WindowGroup
- Enable WindowScreenshotPopover functionality in cursor windows list
- Improve menu bar highlight state tracking when popover is active
- Clean up legacy MenuBarIconManager implementation and tests

The new implementation provides better visual feedback about monitoring state
while maintaining a subtle, professional appearance that integrates seamlessly
with the macOS menu bar.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: steipete

App/AppDelegate.swift

@@ -52,6 +52,9 @@ public final class AppDelegate: NSObject, NSApplicationDelegate, ObservableObjec
     public static var shared: AppDelegate? {
         NSApp.delegate as? AppDelegate
     }
+    
+    // Status bar controller - initialized later
+    private var statusBarController: StatusBarController?
 
     // View models and coordinators
     public var mainSettingsCoordinator: MainSettingsCoordinator?
@@ -97,6 +100,9 @@ public final class AppDelegate: NSObject, NSApplicationDelegate, ObservableObjec
 
         // Initialize core services FIRST
         initializeServices() // Ensure windowManager and other services are ready
+        
+        // Initialize status bar controller after services are ready
+        statusBarController = StatusBarController.shared
 
         // Sync login item state with user preference after services are up
         if !Constants.isTestEnvironment {
@@ -297,7 +303,7 @@ public final class AppDelegate: NSObject, NSApplicationDelegate, ObservableObjec
         loginItemManager = LoginItemManager.shared
 
         _ = self.locatorManager
-        _ = MenuBarIconManager.shared // Ensure shared instance is initialized
+        // Note: MenuBarIconManager removed - now using SwiftUI MenuBarExtra in CodeLooperApp.swift
 
         // Initialize Sparkle with error handling to prevent dialogs
         sparkleUpdaterManager = SparkleUpdaterManager()
@@ -399,6 +405,7 @@ public final class AppDelegate: NSObject, NSApplicationDelegate, ObservableObjec
         // Initialize WelcomeWindowCoordinator to ensure it's listening for notifications
         _ = WelcomeWindowCoordinator.shared
 
+
         logger.info("Application startup completed successfully")
     }
 
@@ -418,7 +425,7 @@ public final class AppDelegate: NSObject, NSApplicationDelegate, ObservableObjec
     @objc private func handleShowSettingsNotification() {
         Task { @MainActor in
             logger.info("Received request to show settings from another instance")
-            SettingsService.openSettingsSubject.send()
+            MainSettingsCoordinator.shared.showSettings()
             NSApp.activate(ignoringOtherApps: true)
         }
     }
@@ -514,6 +521,7 @@ public final class AppDelegate: NSObject, NSApplicationDelegate, ObservableObjec
         }
     }
 
+
     // MARK: - Global Tint Setup
 
     private func setupGlobalTint() {

App/CodeLooperApp.swift

@@ -4,7 +4,6 @@ import DesignSystem
 import Diagnostics
 import KeyboardShortcuts
 import Logging
-import MenuBarExtraAccess
 import os
 import SwiftUI
 
@@ -54,25 +53,10 @@ struct CodeLooperApp: App {
     @NSApplicationDelegateAdaptor(AppDelegate.self) var appDelegate
 
     var body: some Scene {
-        MenuBarExtra {
-            menuBarContent
-        } label: {
-            MenuBarIconView() // Use the new struct for the label
-                .environmentObject(cursorMonitor)
-                .environmentObject(appIconStateController)
+        // No window groups - settings are handled by MainSettingsCoordinator
+        Settings {
+            EmptyView()
         }
-        .menuBarExtraStyle(.window)
-        .menuBarExtraAccess(isPresented: $isMenuPresented) { _ in
-        }
-
-        WindowGroup("CodeLooper", id: "settings") {
-            SettingsSceneView()
-                .environmentObject(sessionLogger)
-        }
-        .windowResizability(.contentSize)
-        .defaultSize(width: 640, height: 800)
-        .commandsRemoved()
-        .handlesExternalEvents(matching: Set(["settings"]))
         .commands {
             CommandGroup(replacing: .appInfo) {
                 Button("About CodeLooper") {
@@ -91,81 +75,11 @@ struct CodeLooperApp: App {
     @StateObject private var cursorMonitor = CursorMonitor.shared
     @StateObject private var sessionLogger = SessionLogger.shared
     @StateObject private var appIconStateController = AppIconStateController.shared // Renamed for clarity
-    @State private var isMenuPresented: Bool = false // For MenuBarExtraAccess
 
     @Default(.isGlobalMonitoringEnabled) private var isGlobalMonitoringEnabled
     @Default(.showDebugMenu) private var showDebugMenu // For the debug menu items
     @Default(.startAtLogin) private var startAtLogin // For the menu item state
 
     // Logger for CodeLooperApp
     private let logger = Logger(category: .app)
-
-    @ViewBuilder
-    private var menuBarContent: some View {
-        MainPopoverView()
-            .environmentObject(sessionLogger)
-            .environmentObject(cursorMonitor)
-    }
-}
-
-struct MenuBarIconView: View {
-    @StateObject private var menuBarIconManager = MenuBarIconManager.shared
-    @EnvironmentObject var appIconStateController: AppIconStateController // Keep for status display
-    @Default(.isGlobalMonitoringEnabled) private var isGlobalMonitoringEnabled
-    @Default(.useDynamicMenuBarIcon) private var useDynamicMenuBarIcon
-
-    var body: some View {
-        HStack(spacing: 4) {
-            // Icon based on user preference
-            if useDynamicMenuBarIcon {
-                // Animated SwiftUI icon
-                AnimatedLoopIcon(size: 16)
-            } else {
-                // Static PNG icon
-                Image("MenuBarTemplateIcon")
-                    .renderingMode(.template)
-                    .frame(width: 16, height: 16)
-            }
-
-            // Display the status text from the manager
-            Text(menuBarIconManager.currentIconAttributedString)
-                .font(.system(size: 12, weight: .medium))
-        }
-        .contentShape(Rectangle())
-    }
-}
-
-struct SettingsSceneView: View {
-    // MARK: Internal
-
-    var body: some View {
-        SettingsContainerView()
-            .environmentObject(mainSettingsViewModel)
-            .onReceive(SettingsService.openSettingsSubject) { _ in
-                // Handle settings opening if needed
-            }
-            .onAppear {
-                ensureSingleSettingsWindow()
-            }
-    }
-
-    // MARK: Private
-
-    @StateObject private var mainSettingsViewModel = MainSettingsViewModel(
-        loginItemManager: LoginItemManager.shared,
-        updaterViewModel: UpdaterViewModel(sparkleUpdaterManager: nil)
-    )
-
-    private func ensureSingleSettingsWindow() {
-        // Close any duplicate settings windows
-        let settingsWindows = NSApp.windows.filter { window in
-            window.title.contains("Settings") || window.identifier?.rawValue == "settings"
-        }
-
-        // Keep only the first one, close the rest
-        for window in settingsWindows.dropFirst() {
-            print("Closing duplicate settings window: \(window.title)")
-            window.close()
-        }
-    }
 }