[codex] Use dashboard credits for Codex cost totals#1683
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 20, 2026, 9:37 AM ET / 13:37 UTC. Summary Reproducibility: yes. for the review finding: source inspection shows dashboard latest-day cost and local top-level session token/request fields are selected independently. I did not run tests because this review was required to keep the checkout read-only. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Keep the dashboard-credit source, but tie copied local token/request context to the matching dashboard day or omit it when dates differ, then require redacted real behavior proof from an attached-dashboard setup before merge. Do we have a high-confidence way to reproduce the issue? Yes for the review finding: source inspection shows dashboard latest-day cost and local top-level session token/request fields are selected independently. I did not run tests because this review was required to keep the checkout read-only. Is this the best way to solve the issue? No, not yet: using dashboard credits as the Codex cost authority is a reasonable path, but the merge logic should only preserve local session context for the same dashboard date. The safer fix is to look up the matching local daily entry or omit mismatched session context. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 3f3e2f4a112a. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
usageBreakdowncredits (Exec/Desktop App/CLI/Unknown) into USD cost totals using the documented 25 credits = $1 conversion.Context
The Codex dashboard already reports service-level credits for Exec usage, but the Cost card was still driven by local token-log pricing. That meant
Execactivity could appear in Subscription Utilization while not contributing to the displayed USD cost totals.OpenAI docs used for the conversion:
Verification
swift test --filter OpenAIDashboardModelsTestsswift test --filter MenuCardCostHintTestsswift test --filter StatusMenuTestsmake checkmake testmake startlaunched the patched localCodexBar.appand reportedOK: CodexBar is running.